public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove the "for moment" comments Date: Wed, 31 Aug 2022 17:14:25 +0000 (GMT) [thread overview] Message-ID: <20220831171425.5A6A63851A96@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8dc84baf2e0c52828d3aed0dc88a48866d07818b commit 8dc84baf2e0c52828d3aed0dc88a48866d07818b Author: Tom Tromey <tromey@adacore.com> Date: Thu Aug 11 10:15:36 2022 -0600 Remove the "for moment" comments A few spots setting some gdb output stream variables have a "for moment" comment. These comments aren't useful and I think the moment has passed -- these are permanent now. Diff: --- gdb/event-top.c | 4 ++-- gdb/main.c | 4 ++-- gdb/tui/tui-io.c | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/event-top.c b/gdb/event-top.c index a06221b1b80..a5f24f6a902 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -1338,8 +1338,8 @@ gdb_setup_readline (int editing) gdb_stdout = new pager_file (new stdio_file (ui->outstream)); gdb_stderr = new stderr_file (ui->errstream); gdb_stdlog = new timestamped_file (gdb_stderr); - gdb_stdtarg = gdb_stderr; /* for moment */ - gdb_stdtargerr = gdb_stderr; /* for moment */ + gdb_stdtarg = gdb_stderr; + gdb_stdtargerr = gdb_stderr; /* If the input stream is connected to a terminal, turn on editing. However, that is only allowed on the main UI, as we can only have diff --git a/gdb/main.c b/gdb/main.c index 8c97987956b..91fa1966738 100644 --- a/gdb/main.c +++ b/gdb/main.c @@ -676,8 +676,8 @@ captured_main_1 (struct captured_main_args *context) main_ui = new ui (stdin, stdout, stderr); current_ui = main_ui; - gdb_stdtargerr = gdb_stderr; /* for moment */ - gdb_stdtargin = gdb_stdin; /* for moment */ + gdb_stdtargerr = gdb_stderr; + gdb_stdtargin = gdb_stdin; if (bfd_init () != BFD_INIT_MAGIC) error (_("fatal error: libbfd ABI mismatch")); diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c index deea9b90afc..51f08168a90 100644 --- a/gdb/tui/tui-io.c +++ b/gdb/tui/tui-io.c @@ -839,8 +839,8 @@ tui_setup_io (int mode) gdb_stdout = tui_stdout; gdb_stderr = tui_stderr; gdb_stdlog = tui_stdlog; - gdb_stdtarg = gdb_stderr; /* for moment */ - gdb_stdtargerr = gdb_stderr; /* for moment */ + gdb_stdtarg = gdb_stderr; + gdb_stdtargerr = gdb_stderr; current_uiout = tui_out; /* Save tty for SIGCONT. */ @@ -852,8 +852,8 @@ tui_setup_io (int mode) gdb_stdout = tui_old_stdout; gdb_stderr = tui_old_stderr; gdb_stdlog = tui_old_stdlog; - gdb_stdtarg = gdb_stderr; /* for moment */ - gdb_stdtargerr = gdb_stderr; /* for moment */ + gdb_stdtarg = gdb_stderr; + gdb_stdtargerr = gdb_stderr; current_uiout = tui_old_uiout; /* Restore readline. */
reply other threads:[~2022-08-31 17:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220831171425.5A6A63851A96@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).