public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove the "for moment" comments
@ 2022-08-31 17:14 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2022-08-31 17:14 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8dc84baf2e0c52828d3aed0dc88a48866d07818b
commit 8dc84baf2e0c52828d3aed0dc88a48866d07818b
Author: Tom Tromey <tromey@adacore.com>
Date: Thu Aug 11 10:15:36 2022 -0600
Remove the "for moment" comments
A few spots setting some gdb output stream variables have a "for
moment" comment. These comments aren't useful and I think the moment
has passed -- these are permanent now.
Diff:
---
gdb/event-top.c | 4 ++--
gdb/main.c | 4 ++--
gdb/tui/tui-io.c | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdb/event-top.c b/gdb/event-top.c
index a06221b1b80..a5f24f6a902 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -1338,8 +1338,8 @@ gdb_setup_readline (int editing)
gdb_stdout = new pager_file (new stdio_file (ui->outstream));
gdb_stderr = new stderr_file (ui->errstream);
gdb_stdlog = new timestamped_file (gdb_stderr);
- gdb_stdtarg = gdb_stderr; /* for moment */
- gdb_stdtargerr = gdb_stderr; /* for moment */
+ gdb_stdtarg = gdb_stderr;
+ gdb_stdtargerr = gdb_stderr;
/* If the input stream is connected to a terminal, turn on editing.
However, that is only allowed on the main UI, as we can only have
diff --git a/gdb/main.c b/gdb/main.c
index 8c97987956b..91fa1966738 100644
--- a/gdb/main.c
+++ b/gdb/main.c
@@ -676,8 +676,8 @@ captured_main_1 (struct captured_main_args *context)
main_ui = new ui (stdin, stdout, stderr);
current_ui = main_ui;
- gdb_stdtargerr = gdb_stderr; /* for moment */
- gdb_stdtargin = gdb_stdin; /* for moment */
+ gdb_stdtargerr = gdb_stderr;
+ gdb_stdtargin = gdb_stdin;
if (bfd_init () != BFD_INIT_MAGIC)
error (_("fatal error: libbfd ABI mismatch"));
diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c
index deea9b90afc..51f08168a90 100644
--- a/gdb/tui/tui-io.c
+++ b/gdb/tui/tui-io.c
@@ -839,8 +839,8 @@ tui_setup_io (int mode)
gdb_stdout = tui_stdout;
gdb_stderr = tui_stderr;
gdb_stdlog = tui_stdlog;
- gdb_stdtarg = gdb_stderr; /* for moment */
- gdb_stdtargerr = gdb_stderr; /* for moment */
+ gdb_stdtarg = gdb_stderr;
+ gdb_stdtargerr = gdb_stderr;
current_uiout = tui_out;
/* Save tty for SIGCONT. */
@@ -852,8 +852,8 @@ tui_setup_io (int mode)
gdb_stdout = tui_old_stdout;
gdb_stderr = tui_old_stderr;
gdb_stdlog = tui_old_stdlog;
- gdb_stdtarg = gdb_stderr; /* for moment */
- gdb_stdtargerr = gdb_stderr; /* for moment */
+ gdb_stdtarg = gdb_stderr;
+ gdb_stdtargerr = gdb_stderr;
current_uiout = tui_old_uiout;
/* Restore readline. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-31 17:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 17:14 [binutils-gdb] Remove the "for moment" comments Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).