public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove a ui-related memory leak Date: Wed, 31 Aug 2022 17:14:55 +0000 (GMT) [thread overview] Message-ID: <20220831171455.C56433858435@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b8043d27217ff89abba733476cb71c3656f5722a commit b8043d27217ff89abba733476cb71c3656f5722a Author: Tom Tromey <tromey@adacore.com> Date: Thu Aug 11 13:16:46 2022 -0600 Remove a ui-related memory leak gdb_setup_readline makes new streams and assigns to the various stream members of struct ui. However, these assignments cause the previous values to leak. As far as I can, this code is simply unnecessary and can be removed -- with the exception of the assignment to gdb_stdtarg, which is not initialized anywhere else. Diff: --- gdb/event-top.c | 11 ----------- gdb/main.c | 1 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/gdb/event-top.c b/gdb/event-top.c index a5f24f6a902..1b522a77d79 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -1330,17 +1330,6 @@ gdb_setup_readline (int editing) { struct ui *ui = current_ui; - /* This function is a noop for the sync case. The assumption is - that the sync setup is ALL done in gdb_init, and we would only - mess it up here. The sync stuff should really go away over - time. */ - if (!batch_silent) - gdb_stdout = new pager_file (new stdio_file (ui->outstream)); - gdb_stderr = new stderr_file (ui->errstream); - gdb_stdlog = new timestamped_file (gdb_stderr); - gdb_stdtarg = gdb_stderr; - gdb_stdtargerr = gdb_stderr; - /* If the input stream is connected to a terminal, turn on editing. However, that is only allowed on the main UI, as we can only have one instance of readline. */ diff --git a/gdb/main.c b/gdb/main.c index 91fa1966738..8d2666ecc95 100644 --- a/gdb/main.c +++ b/gdb/main.c @@ -676,6 +676,7 @@ captured_main_1 (struct captured_main_args *context) main_ui = new ui (stdin, stdout, stderr); current_ui = main_ui; + gdb_stdtarg = gdb_stderr; gdb_stdtargerr = gdb_stderr; gdb_stdtargin = gdb_stdin;
reply other threads:[~2022-08-31 17:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220831171455.C56433858435@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).