public inbox for
help / color / mirror / Atom feed
From: Tsukasa OI <>
Subject: [binutils-gdb] gdb: Add non-enum disassembler options
Date: Tue,  6 Sep 2022 08:28:21 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=f2028892699ded3276246ddec602d6b9f3e7295d

commit f2028892699ded3276246ddec602d6b9f3e7295d
Author: Tsukasa OI <>
Date:   Tue Aug 30 12:21:13 2022 +0000

    gdb: Add non-enum disassembler options
    This is paired with "opcodes: Add non-enum disassembler options".
    There is a portable mechanism for disassembler options and used on some
    -   ARC
    -   Arm
    -   MIPS
    -   PowerPC
    -   RISC-V
    -   S/390
    However, it only supports following forms:
    -   [NAME]
    -   [NAME]=[ENUM_VALUE]
    Valid values for [ENUM_VALUE] must be predefined in
    disasm_option_arg_t.values. For instance, for -M cpu=[CPU] in ARC
    architecture, opcodes/arc-dis.c builds valid CPU model list from
    In this commit, it adds following format:
    -   [NAME]=[ARBITRARY_VALUE] (cannot contain "," though)
    This is identified by NULL value of disasm_option_arg_t.values
    (normally, this is a non-NULL pointer to a NULL-terminated list).
            * gdb/disasm.c (set_disassembler_options): Add support for
            non-enum disassembler options.
            (show_disassembler_options_sfunc): Likewise.

 gdb/disasm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gdb/disasm.c b/gdb/disasm.c
index db6724757ac..fe4eed2d524 100644
--- a/gdb/disasm.c
+++ b/gdb/disasm.c
@@ -1270,6 +1270,8 @@ set_disassembler_options (const char *prospective_options)
 	    if (memcmp (opt, valid_options->name[i], len) != 0)
 	    arg = opt + len;
+	    if (valid_options->arg[i]->values == NULL)
+	      break;
 	    for (j = 0; valid_options->arg[i]->values[j] != NULL; j++)
 	      if (disassembler_options_cmp
 		    (arg, valid_options->arg[i]->values[j]) == 0)
@@ -1391,6 +1393,8 @@ The following disassembler options are supported for use with the\n\
       for (i = 0; valid_args[i].name != NULL; i++)
+	  if (valid_args[i].values == NULL)
+	    continue;
 	  gdb_printf (file, _("\n\
   For the options above, the following values are supported for \"%s\":\n   "),

                 reply	other threads:[~2022-09-06  8:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).