From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id CC4D73858D28; Wed, 7 Sep 2022 17:14:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC4D73858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662570861; bh=/Es4rfT5QrGykkJYM5O/4hleECrYmWuBVbJYWlSK4Qk=; h=From:To:Subject:Date:From; b=Ci/GurcupV0cnT1YNDFBxfoW6Sc7mWE5drHa/6viBweluR/+zdIVrNka89nYt5QWy AEKFVPrn+K6bIpIq6m/G7uXg2Qb4Pa0Phix8EzYxJ5WyFVR+kHvlCrXRGwD5DAPuBl xiCO0KRJ65s18bfV4HTtvr5y4P0tU/md88arUmlE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] xfail gdb.ada/O2_float_param.exp for aarch64 and gcc 7.5.0 X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: 154f2735ad4c2eb0985086b113825e6f4f3abcf1 X-Git-Newrev: d6398d6713ee13872056d3bd798add314d45aebf Message-Id: <20220907171421.CC4D73858D28@sourceware.org> Date: Wed, 7 Sep 2022 17:14:21 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dd6398d6713ee= 13872056d3bd798add314d45aebf commit d6398d6713ee13872056d3bd798add314d45aebf Author: Tom de Vries Date: Wed Sep 7 19:14:17 2022 +0200 [gdb/testsuite] xfail gdb.ada/O2_float_param.exp for aarch64 and gcc 7.= 5.0 =20 On aarch64-linux, with gcc 7.5.0, we run into: ... (gdb) frame^M #0 callee.increment (val=3D99.0, val@entry=3D9.18340949e-41, msg=3D..= .) at \ callee.adb:21^M 21 if Val > 200.0 then^M (gdb) FAIL: gdb.ada/O2_float_param.exp: scenario=3Dall: frame ... =20 The problem is a GCC bug, filed as "PR98148 - [AArch64] Wrong location expression for function entry values" ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98148 ). =20 Xfail the test for aarch64 and gcc 7. =20 Tested on x86_64-linux and aarch64-linux. =20 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29418 Diff: --- gdb/testsuite/gdb.ada/O2_float_param.exp | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.ada/O2_float_param.exp b/gdb/testsuite/gdb.a= da/O2_float_param.exp index 0c2969e0c4f..062a27572f5 100644 --- a/gdb/testsuite/gdb.ada/O2_float_param.exp +++ b/gdb/testsuite/gdb.ada/O2_float_param.exp @@ -19,6 +19,13 @@ if { [skip_ada_tests] } { return -1 } =20 standard_ada_testfile foo =20 +set have_xfail 0 +if { [is_aarch64_target] } then { + if { [gcc_major_version] <=3D 8 } { + set have_xfail 1 + } +} + foreach_with_prefix scenario {all minimal} { set flags [list debug \ optimize=3D-O2 \ @@ -32,6 +39,21 @@ foreach_with_prefix scenario {all minimal} { =20 runto "increment" =20 - gdb_test "frame" \ + set re \ "#0\\s+callee\\.increment \\(val(=3Dval@entry)?=3D99\\.0, msg=3D\\.\\.\\.= \\).*" + set re_different_entry_val \ + "#0\\s+callee\\.increment \\(val=3D99.0, val@entry=3D.*, msg=3D\\.\= \.\\.\\).*" + gdb_test_multiple "frame" "" { + -re -wrap $re { + pass $gdb_test_name + } + -re -wrap $re_different_entry_val { + if { $have_xfail } { + # GCC PR98148 + xfail $gdb_test_name + } else { + fail $gdb_test_name + } + } + } }