public inbox for
help / color / mirror / Atom feed
From: Tom de Vries <>
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp for ppc64le
Date: Mon, 12 Sep 2022 08:05:29 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=52b920c5d2098a7319bcae3f31c0d1fb58d40c38

commit 52b920c5d2098a7319bcae3f31c0d1fb58d40c38
Author: Tom de Vries <>
Date:   Mon Sep 12 10:05:18 2022 +0200

    [gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp for ppc64le
    In commit cd919f5533c ("[gdb/testsuite] Fix
    gdb.dwarf2/dw2-dir-file-name.exp"), I made gdb.dwarf2/dw2-dir-file-name.exp
    independent of prologue analyzers, using this change:
    -       gdb_breakpoint $func
    +       gdb_breakpoint *$func
    That however caused a regression on ppc64le.  For PowerPC, as described in the
    ELFv2 ABI, a function can have a global and local entry point.
    Setting a breakpoint on *$func effectively creates a breakpoint for the global
    entry point, so if the function is entered through the local entry point, the
    breakpoint doesn't trigger.
    Fix this by reverting commit cd919f5533c, and setting the breakpoint on
    ${func}_label instead.
    Tested on x86_64-linux and ppc64le-linux.

 gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp | 8 ++++----
 gdb/testsuite/lib/gdb.exp                      | 7 +------
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
index 08b5c645fa2..053f7229537 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
@@ -450,20 +450,20 @@ proc test { func compdir filename } {
 	    error "not absolute"
-	gdb_breakpoint *$func
+	gdb_breakpoint ${func}_label
 	gdb_continue_to_breakpoint $func "$func \\(\\) at .*"
 	gdb_test_no_output "set filename-display absolute"
 	verbose -log "expect: ${absolute}"
-	gdb_test "frame" "#0  $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute"
+	gdb_test "frame" " in $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute"
 	gdb_test_no_output "set filename-display basename"
 	verbose -log "expect: [file tail $filename]"
-	gdb_test "frame" "#0  $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename"
+	gdb_test "frame" " in $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename"
 	gdb_test_no_output "set filename-display relative"
 	verbose -log "expect: $filename"
-	gdb_test "frame" "#0  $func \\(\\) at [string_to_regexp $filename]:999" "relative"
+	gdb_test "frame" " in $func \\(\\) at [string_to_regexp $filename]:999" "relative"
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 17523f82996..2f1147159ad 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -787,14 +787,9 @@ proc gdb_continue_to_breakpoint {name {location_pattern .*}} {
     global gdb_prompt
     set full_name "continue to breakpoint: $name"
-    set re_at_in " (at|in) "
-    if { [regexp $re_at_in $location_pattern] } {
-	set re_at_in " "
-    }
     set kfail_pattern "Process record does not support instruction 0xfae64 at.*"
     gdb_test_multiple "continue" $full_name {
-	-re "(?:Breakpoint|Temporary breakpoint) .*$re_at_in$location_pattern\r\n$gdb_prompt $" {
+	-re "(?:Breakpoint|Temporary breakpoint) .* (at|in) $location_pattern\r\n$gdb_prompt $" {
 	    pass $full_name
 	-re "\[\r\n\]*(?:$kfail_pattern)\[\r\n\]+$gdb_prompt $" {

                 reply	other threads:[~2022-09-12  8:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).