public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Enze Li <lienze@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler Date: Mon, 19 Sep 2022 12:48:33 +0000 (GMT) [thread overview] Message-ID: <20220919124833.9F4513858D1E@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=77b7377bc4c8d404de00c5a360e64daee75acf80 commit 77b7377bc4c8d404de00c5a360e64daee75acf80 Author: Enze Li <enze.li@hotmail.com> Date: Mon Sep 19 20:43:50 2022 +0800 gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler I see this error when building with clang, CXX gdb_bfd.o gdb_bfd.c:1180:43: error: format string is not a string literal [-Werror,-Wformat-nonliteral] const std::string str = string_vprintf (fmt, ap_copy); ^~~ 1 error generated. This patch adds missing ATTRIBUTE_PRINTF to fix the error. Tested on x86_64-linux with gcc 12 and clang 14. Diff: --- gdb/gdb_bfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 6299148d419..c5a5ed95e8e 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -1170,7 +1170,7 @@ static bfd_error_handler_type default_bfd_error_handler; messages which have been printed once already. This is done on a per-inferior basis. */ -static void +static void ATTRIBUTE_PRINTF (1, 0) gdb_bfd_error_handler (const char *fmt, va_list ap) { va_list ap_copy;
reply other threads:[~2022-09-19 12:48 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220919124833.9F4513858D1E@sourceware.org \ --to=lienze@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).