public inbox for
help / color / mirror / Atom feed
* [binutils-gdb] gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler
@ 2022-09-19 12:48 Enze Li
  0 siblings, 0 replies; only message in thread
From: Enze Li @ 2022-09-19 12:48 UTC (permalink / raw)
  To: gdb-cvs;h=77b7377bc4c8d404de00c5a360e64daee75acf80

commit 77b7377bc4c8d404de00c5a360e64daee75acf80
Author: Enze Li <>
Date:   Mon Sep 19 20:43:50 2022 +0800

    gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler
    I see this error when building with clang,
      CXX    gdb_bfd.o
    gdb_bfd.c:1180:43: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
      const std::string str = string_vprintf (fmt, ap_copy);
    1 error generated.
    This patch adds missing ATTRIBUTE_PRINTF to fix the error.
    Tested on x86_64-linux with gcc 12 and clang 14.

 gdb/gdb_bfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c
index 6299148d419..c5a5ed95e8e 100644
--- a/gdb/gdb_bfd.c
+++ b/gdb/gdb_bfd.c
@@ -1170,7 +1170,7 @@ static bfd_error_handler_type default_bfd_error_handler;
    messages which have been printed once already.  This is done on a
    per-inferior basis.  */
-static void
+static void ATTRIBUTE_PRINTF (1, 0)
 gdb_bfd_error_handler (const char *fmt, va_list ap)
   va_list ap_copy;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-19 12:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 12:48 [binutils-gdb] gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler Enze Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).