public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove current_target_so_ops Date: Tue, 20 Sep 2022 18:40:43 +0000 (GMT) [thread overview] Message-ID: <20220920184043.54E9338582BB@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5898c79ae692ed02dd9267888541b352423a9331 commit 5898c79ae692ed02dd9267888541b352423a9331 Author: Tom Tromey <tromey@adacore.com> Date: Mon Aug 8 10:14:53 2022 -0600 Remove current_target_so_ops current_target_so_ops is only set in a single place. It seems better to simply remove it. Diff: --- gdb/solib-target.c | 5 ----- gdb/solib.c | 9 +++------ gdb/solist.h | 3 --- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/gdb/solib-target.c b/gdb/solib-target.c index 54b98243e51..8def640a1e7 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -453,9 +453,4 @@ _initialize_solib_target () solib_target_so_ops.in_dynsym_resolve_code = solib_target_in_dynsym_resolve_code; solib_target_so_ops.bfd_open = solib_bfd_open; - - /* Set current_target_so_ops to solib_target_so_ops if not already - set. */ - if (current_target_so_ops == 0) - current_target_so_ops = &solib_target_so_ops; } diff --git a/gdb/solib.c b/gdb/solib.c index 25adf586a02..859d345f39c 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -53,6 +53,7 @@ #include "debuginfod-support.h" #include "source.h" #include "cli/cli-style.h" +#include "solib-target.h" /* Architecture-specific operations. */ @@ -67,8 +68,8 @@ solib_ops (struct gdbarch *gdbarch) const struct target_so_ops *result = solib_data.get (gdbarch); if (result == nullptr) { - result = current_target_so_ops; - set_solib_ops (gdbarch, current_target_so_ops); + result = &solib_target_so_ops; + set_solib_ops (gdbarch, &solib_target_so_ops); } return result; } @@ -84,10 +85,6 @@ set_solib_ops (struct gdbarch *gdbarch, const struct target_so_ops *new_ops) /* external data declarations */ -/* FIXME: gdbarch needs to control this variable, or else every - configuration needs to call set_solib_ops. */ -struct target_so_ops *current_target_so_ops; - /* Local function prototypes */ /* If non-empty, this is a search path for loading non-absolute shared library diff --git a/gdb/solist.h b/gdb/solist.h index 34198dc0c4d..f102605e076 100644 --- a/gdb/solist.h +++ b/gdb/solist.h @@ -194,7 +194,4 @@ extern gdb_bfd_ref_ptr solib_bfd_fopen (const char *pathname, int fd); /* Find solib binary file and open it. */ extern gdb_bfd_ref_ptr solib_bfd_open (const char *in_pathname); -/* FIXME: gdbarch needs to control this variable. */ -extern struct target_so_ops *current_target_so_ops; - #endif
reply other threads:[~2022-09-20 18:40 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220920184043.54E9338582BB@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).