From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7862) id B76CD38582A1; Thu, 22 Sep 2022 09:05:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B76CD38582A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1663837514; bh=W7W9rQlDGg44XP6Qcbnz8B+4n/sahyeVDgQejrJjstU=; h=From:To:Subject:Date:From; b=QCF+VaJW2coHosHvWgiaHcIvl9X2DEffdpOzEZ1fJQo7r/obfQpqMlambwpi8+Uz+ rXXLS6xQ6/B/IeeotRZT4ZKeB5keQwsdln6lrRSGYLbHzWs97X2ake9au9QcLYOwXB jdiXbVfYo6OIv6mjp8ymsjMXjYj5r9q8gCygVav0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Bruno Larsen To: gdb-cvs@sourceware.org Subject: [binutils-gdb] fix gdb.base/jit-elf.exp when testing with clang X-Act-Checkin: binutils-gdb X-Git-Author: Bruno Larsen X-Git-Refname: refs/heads/master X-Git-Oldrev: 8d215439f665e51adc55dc2c4ba743ee576cb2fc X-Git-Newrev: 53d4a55bebf56c5ceb6bcf7ff43efd05043a0fc7 Message-Id: <20220922090514.B76CD38582A1@sourceware.org> Date: Thu, 22 Sep 2022 09:05:14 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D53d4a55bebf5= 6c5ceb6bcf7ff43efd05043a0fc7 commit 53d4a55bebf56c5ceb6bcf7ff43efd05043a0fc7 Author: Bruno Larsen Date: Wed Jul 20 16:44:38 2022 -0300 fix gdb.base/jit-elf.exp when testing with clang =20 When using clang as the compiler for the target, gdb.base/jit-elf.exp was failing because the filename displayed when GDB attached to the inferior was only showing up as with a relative path, like so: =20 (gdb) attach 3674146 Attaching to program: /home/blarsen/Documents/gdb-build/gdb/test= suite/outputs/gdb.base/jit-elf/jit-elf-main, process 3674146 Reading symbols from /lib64/libm.so.6... Reading symbols from .gnu_debugdata for /lib64/libm.so.6... (No debugging symbols found in .gnu_debugdata for /lib64/libm.so= .6) Reading symbols from /lib64/libc.so.6... (No debugging symbols found in /lib64/libc.so.6) Reading symbols from /lib64/ld-linux-x86-64.so.2... [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". 0x00000000004013ff in main (argc=3D3, argv=3D0x7fffffffd820) at = ../../../common/git-repos/binutils-gdb/gdb/testsuite/gdb.base/jit-elf-main.= c:118 118| WAIT_FOR_GDB; i =3D 0; /* gdb break here 1 */ (gdb) FAIL: gdb.base/jit-elf.exp: attach: one_jit_test-2: break = here 1: attach =20 While gcc's output is as follows: =20 (gdb) attach 3592961 Attaching to program: /home/blarsen/Documents/gdb-build/gdb/test= suite/outputs/gdb.base/jit-elf/jit-elf-main, process 3592961 Reading symbols from /lib64/libm.so.6... Reading symbols from .gnu_debugdata for /lib64/libm.so.6... (No debugging symbols found in .gnu_debugdata for /lib64/libm.so= .6) Reading symbols from /lib64/libc.so.6... (No debugging symbols found in /lib64/libc.so.6) Reading symbols from /lib64/ld-linux-x86-64.so.2... [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". main (argc=3D3, argv=3D0x7fffffffd860) at /home/blarsen/Document= s/gdb-build/gdb/testsuite/../../../common/git-repos/binutils-gdb/gdb/testsu= ite/gdb.base/jit-elf-main.c:118 118| WAIT_FOR_GDB; i =3D 0; /* gdb break here 1 */ (gdb) PASS: gdb.base/jit-elf.exp: attach: one_jit_test-2: break = here 1: attach =20 This difference only happens when GDB's configure is ran using a relative path, but seeing as testing the full path is not important for this specific test, it feels worth fixing anyway. To fix the false positive, the regexp for checking where gdb has stopped was relaxed a little to allow the relative path. Diff: --- gdb/testsuite/gdb.base/jit-elf.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/jit-elf.exp b/gdb/testsuite/gdb.base/ji= t-elf.exp index 38d541f74b9..0753072974f 100644 --- a/gdb/testsuite/gdb.base/jit-elf.exp +++ b/gdb/testsuite/gdb.base/jit-elf.exp @@ -54,7 +54,7 @@ proc clean_reattach {} { clean_restart ${main_binfile} =20 if { ![gdb_attach $testpid \ - -pattern "main.*at .*$::main_srcfile:.*"] } { + -pattern "main.*at .*$::main_basename.c:.*"] } { return 0 }