public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Add aranges to gdb.dwarf2/dw2-dir-file-name.exp
@ 2022-09-30  3:58 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-09-30  3:58 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=511f4ff4d9bcaed1ed53ee64211d7c9f80f07fed

commit 511f4ff4d9bcaed1ed53ee64211d7c9f80f07fed
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Sep 30 05:58:43 2022 +0200

    [gdb/testsuite] Add aranges to gdb.dwarf2/dw2-dir-file-name.exp
    
    Since commit 52b920c5d20 ("[gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp
    for ppc64le"), the test-case fails with target board cc-with-debug-names, due
    to missing .debug_aranges info.
    
    Add the missing .debug_aranges info.
    
    Also add a file_id option to Dwarf::assemble, to make it possible to contribute
    to an already open file.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp | 16 ++++++++++++++++
 gdb/testsuite/lib/dwarf.exp                    | 15 +++++++++++++--
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
index 3827ed744b5..d9d34440b16 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
@@ -317,6 +317,22 @@ puts -nonewline $f "\
 "
 out_compdir out_cu
 
+Dwarf::assemble { add_dummy_cus 0 file_id $f } {
+    global func_info_names
+
+    foreach name $func_info_names {
+	global ${name}_start
+	global ${name}_end
+	set name_start [set ${name}_start]
+	set name_end [set ${name}_end]
+
+	set cu_label .L${name}_begin
+	aranges {} cu_label {
+	    arange {} $name_start "$name_end - $name_start"
+	}
+    }
+}
+
 puts $f "  .section .debug_line"
 out_compdir out_line
 
diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index 6db0ed28deb..b85ec290299 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -3193,6 +3193,9 @@ namespace eval Dwarf {
     #           - the name of the file where the generated assembly
     #             code is written.
     #             default = "".
+    # file_id <tcl channel identifier>
+    #           - open file where the generated assemble core is written.
+    #             default = "".
     #  add_dummy_cus <0|1>
     #           - Whether to add dummy CUs before and after the CUs
     #             added in the BODY.
@@ -3233,6 +3236,7 @@ namespace eval Dwarf {
 
 	parse_options {
 	    { filename "" }
+	    { file_id "" }
 	    { add_dummy_cus 1 }
 	}
 
@@ -3241,7 +3245,12 @@ namespace eval Dwarf {
 	    set _initialized 1
 	}
 
-	set _output_file [open $filename w]
+	if { $file_id != "" } {
+	    set _output_file $file_id
+	} else {
+	    set _output_file [open $filename w]
+	}
+
 	set _cu_count -1
 	_empty_array _deferred_output
 	set _defer ""
@@ -3274,7 +3283,9 @@ namespace eval Dwarf {
 
 	_write_deferred_output
 
-	catch {close $_output_file}
+	if { $file_id == "" } {
+	    catch {close $_output_file}
+	}
 	set _output_file {}
     }
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-30  3:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30  3:58 [binutils-gdb] [gdb/testsuite] Add aranges to gdb.dwarf2/dw2-dir-file-name.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).