From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7896) id B80783858D1E; Fri, 30 Sep 2022 04:01:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B80783858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664510478; bh=L+tXpDgTex6bVDelbo93o5aBpNsO4ehUr847PRGlV0M=; h=From:To:Subject:Date:From; b=qbAe1Ix8tPeqT1C2tJG1lb5NZBd7EB00aifZ9M1p+nLycsX2yuz8rvjZKfoCvKtno rfCXxJC7XHU1rE4j/pI7lIkhFcpEyiXgZdpzlK2ObO59rnazp+yD+xiNl3UQt7iwKu +0p0BuPNmcLR4r+NE5wdC9hUV30skAcCcGIhgrnA= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tsukasa OI To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: Remove unused extra_lines variable X-Act-Checkin: binutils-gdb X-Git-Author: Tsukasa OI X-Git-Refname: refs/heads/master X-Git-Oldrev: 511f4ff4d9bcaed1ed53ee64211d7c9f80f07fed X-Git-Newrev: f3700471469ac0f395961e92892bc5d6e17ca177 Message-Id: <20220930040118.B80783858D1E@sourceware.org> Date: Fri, 30 Sep 2022 04:01:18 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Df3700471469a= c0f395961e92892bc5d6e17ca177 commit f3700471469ac0f395961e92892bc5d6e17ca177 Author: Tsukasa OI Date: Sat Sep 24 09:25:57 2022 +0000 gdb: Remove unused extra_lines variable =20 Clang generates a warning if there is a variable that is set but not us= ed otherwise ("-Wunused-but-set-variable"). On the default configuration,= it causes a build failure (unless "--disable-werror" is specified). =20 The only extra_lines use in arrange_linetable function is removed on the commit 558802e4d1c5dcbd0df7d2c6ef62a6deac247a2f ("gdb: change subfile::line_vector to an std::vector"). So, this varia= ble should be removed to prevent a build failure. Diff: --- gdb/xcoffread.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index b7d65771115..aa88cbc724d 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -419,8 +419,6 @@ add_stab_to_list (char *stabname, struct pending_stabs = **stabvector) static void arrange_linetable (std::vector &old_linetable) { - int extra_lines =3D 0; - std::vector fentries; =20 for (int ii =3D 0; ii < old_linetable.size (); ++ii) @@ -436,12 +434,6 @@ arrange_linetable (std::vector &old_l= inetable) e.line =3D ii; e.is_stmt =3D 1; e.pc =3D old_linetable[ii].pc; - - /* If the function was compiled with XLC, we may have to add an - extra line entry later. Reserve space for that. */ - if (ii + 1 < old_linetable.size () - && old_linetable[ii].pc !=3D old_linetable[ii + 1].pc) - extra_lines++; } }