public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix path in test name in gdb_load_shlib
Date: Fri,  7 Oct 2022 14:17:40 +0000 (GMT)	[thread overview]
Message-ID: <20221007141740.4E50F3858C56@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8ed73e316466987d0d33ce9e21ebc8ff9aa4c4d7

commit 8ed73e316466987d0d33ce9e21ebc8ff9aa4c4d7
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Oct 7 16:17:34 2022 +0200

    [gdb/testsuite] Fix path in test name in gdb_load_shlib
    
    When running test-case gdb.server/solib-list.exp with target board
    remote-gdbserver-on-localhost, I run into:
    ...
    (gdb) set solib-search-path $outputs/gdb.server/solib-list^M
    (gdb) PASS: gdb.server/solib-list.exp: non-stop 0: \
      set solib-search-path $outputs/gdb.server/solib-list
    PATH: gdb.server/solib-list.exp: non-stop 0: \
      set solib-search-path $outputs/gdb.server/solib-list
    ...
    
    This is due to this code in gdb_load_shlib:
    ...
           gdb_test "set solib-search-path [file dirname $file]" "" ""
    ...
    
    Fix this by setting an explicit test name.
    
    Tested on x86_64-linux, with native and target boards
    remote-gdbserver-on-localhost, native-gdbserver and native-extended-gdbserver.

Diff:
---
 gdb/testsuite/lib/gdb.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 432ed5e34ca..d60dceffd3f 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5614,7 +5614,8 @@ proc gdb_load_shlib { file } {
 	# We could set this even when not testing remotely, but a user
 	# generally won't set it unless necessary.  In order to make the tests
 	# more like the real-life scenarios, we don't set it for local testing.
-	gdb_test "set solib-search-path [file dirname $file]" "" ""
+	gdb_test "set solib-search-path [file dirname $file]" "" \
+	    "set solib-search-path for [file tail $file]"
     }
 
     return $dest

                 reply	other threads:[~2022-10-07 14:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007141740.4E50F3858C56@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).