public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: use 'end' at the end of python blocks Date: Mon, 10 Oct 2022 09:29:07 +0000 (GMT) [thread overview] Message-ID: <20221010092907.645673858406@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f91822c2b9f9fed0c2717b17f380e5216502ea32 commit f91822c2b9f9fed0c2717b17f380e5216502ea32 Author: Andrew Burgess <aburgess@redhat.com> Date: Sat Oct 8 16:58:00 2022 +0100 gdb/testsuite: use 'end' at the end of python blocks Within the testsuite, use the keyword 'end' to terminate blocks of Python code being sent to GDB, rather than sending \004. I could only find three instances of this, all in tests that I originally wrote. I have no memory of there being any special reason why I used \004 instead of 'end' - I assume I copied this from somewhere else that has since changed. Non of the tests being changed here are specifically about whether \004 can be used to terminate a Python block, so I think switching to the more standard 'end' keyword is the right choice. Diff: --- gdb/testsuite/gdb.base/style.exp | 2 +- gdb/testsuite/gdb.python/py-arch-reg-groups.exp | 2 +- gdb/testsuite/gdb.python/py-arch-reg-names.exp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp index c6ed996c280..146e2b6d757 100644 --- a/gdb/testsuite/gdb.base/style.exp +++ b/gdb/testsuite/gdb.base/style.exp @@ -444,7 +444,7 @@ proc test_disassembler_error_handling { } { "def replacement_colorize_disasm(content,gdbarch):" \ " return None" \ "gdb.styling.colorize_disasm = replacement_colorize_disasm" \ - "\004"] \ + "end"] \ "setup replacement colorize_disasm function" \ true diff --git a/gdb/testsuite/gdb.python/py-arch-reg-groups.exp b/gdb/testsuite/gdb.python/py-arch-reg-groups.exp index 9503e6c10f5..f2cf8b0e6ec 100644 --- a/gdb/testsuite/gdb.python/py-arch-reg-groups.exp +++ b/gdb/testsuite/gdb.python/py-arch-reg-groups.exp @@ -102,5 +102,5 @@ gdb_py_test_silent_cmd \ " raise gdb.GdbError (\"miss-matched names\")" \ " if (r1 != r2):" \ " raise gdb.GdbError (\"miss-matched objects\")" \ - "\004" ] \ + "end" ] \ "check names and objects match" 1 diff --git a/gdb/testsuite/gdb.python/py-arch-reg-names.exp b/gdb/testsuite/gdb.python/py-arch-reg-names.exp index d3c600ffc0f..62c47e8200e 100644 --- a/gdb/testsuite/gdb.python/py-arch-reg-names.exp +++ b/gdb/testsuite/gdb.python/py-arch-reg-names.exp @@ -102,7 +102,7 @@ gdb_py_test_silent_cmd \ " raise gdb.GdbError (\"miss-matched names\")" \ " if (r1 != r2):" \ " raise gdb.GdbError (\"miss-matched objects\")" \ - "\004" ] \ + "end" ] \ "check names and objects match" 1 # Ensure that the '.find' method on the iterator returns the same
reply other threads:[~2022-10-10 9:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221010092907.645673858406@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).