public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Boolify need_escape in generic_emit_char Date: Mon, 10 Oct 2022 17:38:34 +0000 (GMT) [thread overview] Message-ID: <20221010173834.2C58938582B3@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3a64633804aca8b4c4852241c70936177664c18a commit 3a64633804aca8b4c4852241c70936177664c18a Author: Tom Tromey <tom@tromey.com> Date: Thu Feb 10 16:57:34 2022 -0700 Boolify need_escape in generic_emit_char This changes 'need_escape' in generic_emit_char to be of type bool, rather than int. Diff: --- gdb/valprint.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/valprint.c b/gdb/valprint.c index 395c6e9dd29..92d72521501 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2075,11 +2075,11 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig, int orig_len, int width, enum bfd_endian byte_order, struct obstack *output, - int quoter, int *need_escapep) + int quoter, bool *need_escapep) { - int need_escape = *need_escapep; + bool need_escape = *need_escapep; - *need_escapep = 0; + *need_escapep = false; /* iswprint implementation on Windows returns 1 for tab character. In order to avoid different printout on this host, we explicitly @@ -2149,7 +2149,7 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig, ++i; } - *need_escapep = 1; + *need_escapep = true; } break; } @@ -2167,7 +2167,7 @@ generic_emit_char (int c, struct type *type, struct ui_file *stream, enum bfd_endian byte_order = type_byte_order (type); gdb_byte *c_buf; - int need_escape = 0; + bool need_escape = false; c_buf = (gdb_byte *) alloca (type->length ()); pack_long (c_buf, type, c); @@ -2332,7 +2332,7 @@ print_converted_chars_to_obstack (struct obstack *obstack, const converted_character *elem; enum {START, SINGLE, REPEAT, INCOMPLETE, FINISH} state, last; gdb_wchar_t wide_quote_char = gdb_btowc (quote_char); - int need_escape = 0; + bool need_escape = false; /* Set the start state. */ idx = 0;
reply other threads:[~2022-10-10 17:38 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221010173834.2C58938582B3@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).