public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove c_printstr
Date: Mon, 10 Oct 2022 17:38:44 +0000 (GMT) [thread overview]
Message-ID: <20221010173844.4D26B3858D37@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3a3bb6eb36a29e3201bfc4cc53e341f4f98e6cf1
commit 3a3bb6eb36a29e3201bfc4cc53e341f4f98e6cf1
Author: Tom Tromey <tom@tromey.com>
Date: Fri Feb 11 18:14:17 2022 -0700
Remove c_printstr
This renames c_printstr, removing a layer of indirection.
Diff:
---
gdb/c-lang.c | 8 ++++----
gdb/c-lang.h | 8 --------
gdb/language.c | 12 ------------
gdb/rust-lang.c | 5 +++--
4 files changed, 7 insertions(+), 26 deletions(-)
diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index d6c56f31616..437f79c025a 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -190,10 +190,10 @@ language_defn::printchar (int c, struct type *type,
characters, or if FORCE_ELLIPSES. */
void
-c_printstr (struct ui_file *stream, struct type *type,
- const gdb_byte *string, unsigned int length,
- const char *user_encoding, int force_ellipses,
- const struct value_print_options *options)
+language_defn::printstr (struct ui_file *stream, struct type *type,
+ const gdb_byte *string, unsigned int length,
+ const char *user_encoding, int force_ellipses,
+ const struct value_print_options *options) const
{
c_string_type str_type;
const char *type_encoding;
diff --git a/gdb/c-lang.h b/gdb/c-lang.h
index b26996c20b1..93515671d80 100644
--- a/gdb/c-lang.h
+++ b/gdb/c-lang.h
@@ -93,14 +93,6 @@ extern void c_value_print (struct value *, struct ui_file *,
extern void c_printchar (int, struct type *, struct ui_file *);
-extern void c_printstr (struct ui_file * stream,
- struct type *elttype,
- const gdb_byte *string,
- unsigned int length,
- const char *user_encoding,
- int force_ellipses,
- const struct value_print_options *options);
-
extern void c_language_arch_info (struct gdbarch *gdbarch,
struct language_arch_info *lai);
diff --git a/gdb/language.c b/gdb/language.c
index 114ee3aedd9..076e429ff55 100644
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -635,18 +635,6 @@ language_defn::value_print_inner
/* See language.h. */
-void
-language_defn::printstr (struct ui_file *stream, struct type *elttype,
- const gdb_byte *string, unsigned int length,
- const char *encoding, int force_ellipses,
- const struct value_print_options *options) const
-{
- c_printstr (stream, elttype, string, length, encoding, force_ellipses,
- options);
-}
-
-/* See language.h. */
-
void
language_defn::print_typedef (struct type *type, struct symbol *new_symbol,
struct ui_file *stream) const
diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index 5539884a98f..8673a908698 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -292,8 +292,9 @@ rust_language::printstr (struct ui_file *stream, struct type *type,
{
/* This is probably some C string, so let's let C deal with
it. */
- c_printstr (stream, type, string, length, user_encoding,
- force_ellipses, options);
+ language_defn::printstr (stream, type, string, length,
+ user_encoding, force_ellipses,
+ options);
return;
}
}
reply other threads:[~2022-10-10 17:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010173844.4D26B3858D37@sourceware.org \
--to=tromey@sourceware.org \
--cc=gdb-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).