public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim/erc32: Add ATTRIBUTE_PRINTF
@ 2022-10-11 14:18 Andrew Burgess
0 siblings, 0 replies; only message in thread
From: Andrew Burgess @ 2022-10-11 14:18 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=682389d557f7fa472b66de568ab0089d754ed757
commit 682389d557f7fa472b66de568ab0089d754ed757
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date: Thu Oct 6 06:36:29 2022 +0000
sim/erc32: Add ATTRIBUTE_PRINTF
Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral"). On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).
To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.
This commit adds ATTRIBUTE_PRINTF to the printf-like functions.
Diff:
---
sim/erc32/interf.c | 2 +-
sim/erc32/sis.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c
index f433b9d55ac..aa3ffdc7ada 100644
--- a/sim/erc32/interf.c
+++ b/sim/erc32/interf.c
@@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis)
return TIME_OUT;
}
-static int
+static int ATTRIBUTE_PRINTF (3, 4)
fprintf_styled (void *stream, enum disassembler_style style,
const char *fmt, ...)
{
diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c
index 1d3ea139c23..f89280b7c0c 100644
--- a/sim/erc32/sis.c
+++ b/sim/erc32/sis.c
@@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis)
return TIME_OUT;
}
-static int
+static int ATTRIBUTE_PRINTF (3, 4)
fprintf_styled (void *stream, enum disassembler_style style,
const char *fmt, ...)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-11 14:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11 14:18 [binutils-gdb] sim/erc32: Add ATTRIBUTE_PRINTF Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).