From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id 5E2DD3858403; Tue, 11 Oct 2022 14:18:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E2DD3858403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665497931; bh=HJ/FByNEWprI3nL0jXSV35qIZOo4nXlPk9gKMWqdx6M=; h=From:To:Subject:Date:From; b=ON1OpEj1C8G/i93T3JxcqlGgJL84TfC1H1gvzvnebqyXC8SVlrPU3N2kwQ5Mp3POZ 4fhGveSpwD2LO/XsHGQnCsLj+LofBpIFYWwrcS/94pMKoD9dvCU0Zwga5GbUHNcGyT zk2C0KaYqipZzK16eo46Y07Vx/9AZoPwplXaNjFw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] sim/erc32: Add ATTRIBUTE_PRINTF X-Act-Checkin: binutils-gdb X-Git-Author: Tsukasa OI X-Git-Refname: refs/heads/master X-Git-Oldrev: a26c7ec2114d75d518cda714cc8a0ec05b745ae5 X-Git-Newrev: 682389d557f7fa472b66de568ab0089d754ed757 Message-Id: <20221011141851.5E2DD3858403@sourceware.org> Date: Tue, 11 Oct 2022 14:18:51 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D682389d557f7= fa472b66de568ab0089d754ed757 commit 682389d557f7fa472b66de568ab0089d754ed757 Author: Tsukasa OI Date: Thu Oct 6 06:36:29 2022 +0000 sim/erc32: Add ATTRIBUTE_PRINTF =20 Clang generates a warning if the format string of a printf-like functio= n is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). =20 To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this rea= son. =20 This commit adds ATTRIBUTE_PRINTF to the printf-like functions. Diff: --- sim/erc32/interf.c | 2 +- sim/erc32/sis.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c index f433b9d55ac..aa3ffdc7ada 100644 --- a/sim/erc32/interf.c +++ b/sim/erc32/interf.c @@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } =20 -static int +static int ATTRIBUTE_PRINTF (3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) { diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c index 1d3ea139c23..f89280b7c0c 100644 --- a/sim/erc32/sis.c +++ b/sim/erc32/sis.c @@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } =20 -static int +static int ATTRIBUTE_PRINTF (3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) {