public inbox for
help / color / mirror / Atom feed
From: Andrew Burgess <>
Subject: [binutils-gdb] sim/m32c: Add ATTRIBUTE_PRINTF
Date: Tue, 11 Oct 2022 14:18:56 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=fe8732f93993b99fb257ebd38b47d64f2e4400b4

commit fe8732f93993b99fb257ebd38b47d64f2e4400b4
Author: Tsukasa OI <>
Date:   Thu Oct 6 06:36:30 2022 +0000

    sim/m32c: Add ATTRIBUTE_PRINTF
    Clang generates a warning if the format string of a printf-like function is
    not a literal ("-Wformat-nonliteral").  On the default configuration, it
    causes a build failure (unless "--disable-werror" is specified).
    To avoid warnings on the printf-like wrapper, it requires proper
    __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.
    This commit adds ATTRIBUTE_PRINTF to the printf-like functions.

 sim/m32c/trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/m32c/trace.c b/sim/m32c/trace.c
index 1888e69122b..2f6373dd5f8 100644
--- a/sim/m32c/trace.c
+++ b/sim/m32c/trace.c
@@ -89,7 +89,7 @@ compare_symbols (const void *ap, const void *bp)
 static char opbuf[1000];
-static int
+static int ATTRIBUTE_PRINTF (2, 3)
 op_printf (char *buf, char *fmt, ...)
   int ret;
@@ -101,7 +101,7 @@ op_printf (char *buf, char *fmt, ...)
   return ret;
-static int
+static int ATTRIBUTE_PRINTF (3, 4)
 op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...)
   int ret;

                 reply	other threads:[~2022-10-11 14:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).