public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim/ppc: Add ATTRIBUTE_PRINTF
@ 2022-10-11 14:19 Andrew Burgess
0 siblings, 0 replies; only message in thread
From: Andrew Burgess @ 2022-10-11 14:19 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3efe5b4d9e431f58a17e38d17419d6bcc3a4dd11
commit 3efe5b4d9e431f58a17e38d17419d6bcc3a4dd11
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date: Thu Oct 6 06:36:32 2022 +0000
sim/ppc: Add ATTRIBUTE_PRINTF
Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral"). On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).
To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.
This commit adds ATTRIBUTE_PRINTF to the printf-like functions.
For the error function defined in sim_calls.c, the ATTRIBUTE_NORETURN
has been moved to the function declaration.
Diff:
---
sim/ppc/misc.h | 8 ++++----
sim/ppc/sim_callbacks.h | 5 ++---
sim/ppc/sim_calls.c | 2 +-
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/sim/ppc/misc.h b/sim/ppc/misc.h
index 784ccfdd37b..08309134337 100644
--- a/sim/ppc/misc.h
+++ b/sim/ppc/misc.h
@@ -30,8 +30,8 @@
#include "ansidecl.h"
#include "filter_filename.h"
-extern void error
-(const char *msg, ...);
+extern void error (const char *msg, ...)
+ ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
#define ASSERT(EXPRESSION) \
do { \
@@ -47,8 +47,8 @@ do { \
extern void *zalloc
(long size);
-extern void dumpf
-(int indent, const char *msg, ...);
+extern void dumpf (int indent, const char *msg, ...)
+ ATTRIBUTE_PRINTF (2, 3);
extern unsigned target_a2i
(int ms_bit_nr,
diff --git a/sim/ppc/sim_callbacks.h b/sim/ppc/sim_callbacks.h
index 08ccd258569..c5f23bf8d64 100644
--- a/sim/ppc/sim_callbacks.h
+++ b/sim/ppc/sim_callbacks.h
@@ -31,9 +31,8 @@
void sim_io_printf_filtered
(const char *msg, ...) ATTRIBUTE_PRINTF_1;
-void ATTRIBUTE_NORETURN error
-(const char *msg, ...);
-
+extern void error (const char *msg, ...)
+ ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
/* External environment:
diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c
index fbc327c94e0..729f6dcb6f3 100644
--- a/sim/ppc/sim_calls.c
+++ b/sim/ppc/sim_calls.c
@@ -388,7 +388,7 @@ sim_io_error (SIM_DESC sd, const char *fmt, ...)
/****/
-void ATTRIBUTE_NORETURN
+void
error (const char *msg, ...)
{
va_list ap;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-11 14:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11 14:19 [binutils-gdb] sim/ppc: Add ATTRIBUTE_PRINTF Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).