public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.debuginfod/fetch_src_and_symbols.exp with native-gdbserver
Date: Tue, 11 Oct 2022 16:11:57 +0000 (GMT)	[thread overview]
Message-ID: <20221011161157.8B8FA3858D28@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=343c2cbd8577101a8057d1459810ff983d07943c

commit 343c2cbd8577101a8057d1459810ff983d07943c
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Oct 11 18:11:52 2022 +0200

    [gdb/testsuite] Fix gdb.debuginfod/fetch_src_and_symbols.exp with native-gdbserver
    
    When running test-case gdb.debuginfod/fetch_src_and_symbols.exp with target
    board native-gdbserver, I get:
    ...
    Running gdb.debuginfod/fetch_src_and_symbols.exp ...
    ERROR: tcl error sourcing gdb.debuginfod/fetch_src_and_symbols.exp.
    ERROR: gdbserver does not support start without extended-remote
        while executing
    "error "gdbserver does not support $command without extended-remote""
        (procedure "gdb_test_multiple" line 51)
        invoked from within
    "gdb_test_multiple $command $message {*}$opts $user_code"
        (procedure "gdb_test" line 56)
        invoked from within
    "gdb_test "start" "Temporary breakpoint.*""
    ...
    
    Fix this by replacing gdb_test "start" with runto_main.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
index d781d7a53c7..8bb9203686d 100644
--- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
+++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
@@ -158,7 +158,9 @@ proc_with_prefix no_url { } {
     # Generate a core file and test that GDB cannot find the
     # executable.
     clean_restart ${binfile}2
-    gdb_test "start" "Temporary breakpoint.*"
+    if ![runto_main] {
+	return -1
+    }
     gdb_test "generate-core-file $::corefile" "Saved corefile $::corefile" \
 	"file [file tail $::corefile] gen"
     file rename -force ${binfile}2 $debugdir

                 reply	other threads:[~2022-10-11 16:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011161157.8B8FA3858D28@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).