From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7896) id 6D4CB3821FE3; Wed, 12 Oct 2022 13:51:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D4CB3821FE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665582673; bh=FynV7o5QgY+k6xoZPTnCIYT1X39HGk7OTHPxnmUCQIA=; h=From:To:Subject:Date:From; b=batKO9TDSRrptWkyAmpPdYtSRji+fE7UjmQ4Jl516ekodkOIzlb+hj//Hg/p9561b YJ6iQBxVzX/T76c0pn9GYtg+iUImPxRklWcCHXcCQk5jaUGamn9E05la2QtDwkzHO0 EGL2JTL9h2NtiaDn6k/9z0vsbOO0/iXSMA5f9XAo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tsukasa OI To: gdb-cvs@sourceware.org Subject: [binutils-gdb] sim/ppc: Fix core_find_mapping diagnostics X-Act-Checkin: binutils-gdb X-Git-Author: Tsukasa OI X-Git-Refname: refs/heads/master X-Git-Oldrev: 182421c9d2eea8c4877d983a2124e591f0aca710 X-Git-Newrev: 4bd531c7ffda1df83b6e54ce11f28a0821e3d59e Message-Id: <20221012135113.6D4CB3821FE3@sourceware.org> Date: Wed, 12 Oct 2022 13:51:13 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D4bd531c7ffda= 1df83b6e54ce11f28a0821e3d59e commit 4bd531c7ffda1df83b6e54ce11f28a0821e3d59e Author: Tsukasa OI Date: Wed Oct 12 12:22:12 2022 +0000 sim/ppc: Fix core_find_mapping diagnostics =20 Because "%p" is the pointer conversion specifier to print a pointer in = an implementation-defined manner, the result with format string containing "0x%p" can be strange. For instance, core_map_find_mapping prints error containing "0x0x...." (processor is not NULL) or "0x(null)" (processor = is NULL) on glibc. =20 This commit replaces "0x%p" with "%p" to prevent unpredictable behavior. Diff: --- sim/ppc/corefile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/ppc/corefile.c b/sim/ppc/corefile.c index b2faef58c5b..ee4e2cf733e 100644 --- a/sim/ppc/corefile.c +++ b/sim/ppc/corefile.c @@ -292,7 +292,7 @@ core_map_find_mapping(core_map *map, mapping =3D mapping->next; } if (abort) - error("core_find_mapping() - access to unmaped address, attach a defau= lt map to handle this - addr=3D0x%x nr_bytes=3D0x%x processor=3D0x%p cia=3D= 0x%x\n", + error("core_find_mapping() - access to unmaped address, attach a defau= lt map to handle this - addr=3D0x%x nr_bytes=3D0x%x processor=3D%p cia=3D0x= %x\n", addr, nr_bytes, (void *) processor, cia); return NULL; }