From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id CDC3E3856089; Wed, 12 Oct 2022 14:50:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDC3E3856089 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665586221; bh=I2C/1TPi4sN/wZu6HYx1ybkZ5aWbvG0rhWUIF83vV20=; h=From:To:Subject:Date:From; b=ZKBFRsITDxRTeDIRMGPgfBYx6YsLfAprsRYQUmlv18EomgUJ6DoIDHqwAc31/ZkWz TbQZlPaqTIsHJ8sCaKAT6nETjCZmvLRxHDMoTazOeExAZbRz8KFpvES2Ab9Epnhc1I dUhkvSEsDXmKH8/OAYeQpAxzuOXkUPrvi99yzCYw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Remove unnecessary perror in some test-cases X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: 7fd882d4ad91916fd8a05148117f05ea9f5d756c X-Git-Newrev: e2800454ce9d89f9c4587bc20ee7c6cd0122c340 Message-Id: <20221012145021.CDC3E3856089@sourceware.org> Date: Wed, 12 Oct 2022 14:50:21 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3De2800454ce9d= 89f9c4587bc20ee7c6cd0122c340 commit e2800454ce9d89f9c4587bc20ee7c6cd0122c340 Author: Tom de Vries Date: Wed Oct 12 16:50:16 2022 +0200 [gdb/testsuite] Remove unnecessary perror in some test-cases =20 On openSUSE Tumbleweed I noticed: ... UNTESTED: gdb.dwarf2/fission-absolute-dwo.exp: fission-absolute-dwo.exp ERROR: failed to compile fission-absolute-dwo ... =20 The ERROR is unnecessary, given that an UNTESTED is already emitted. =20 Furthermore, it could be argued that it is incorrect because it's not a testsuite error to not be able to compile something, and UNTESTED or UNSUPPORTED is more appropriate. =20 Remove the perror call, likewise in fission-relative-dwo.exp. =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp | 1 - gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp | 1 - 2 files changed, 2 deletions(-) diff --git a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp b/gdb/testsu= ite/gdb.dwarf2/fission-absolute-dwo.exp index e243598841e..53150237408 100644 --- a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp +++ b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp @@ -112,7 +112,6 @@ set object_file [standard_output_file ${testfile}.o] if { [build_executable_and_dwo_files "${testfile}.exp" ${binfile} {nodebug= } \ [list $asm_file {nodebug split-dwo} ${object_file}] \ [list $srcfile {nodebug}]] } { - perror "failed to compile ${gdb_test_file_name}" return -1 } =20 diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp b/gdb/testsu= ite/gdb.dwarf2/fission-relative-dwo.exp index 62d79412582..3b548c4e8b5 100644 --- a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp +++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp @@ -109,7 +109,6 @@ set object_file [standard_output_file ${testfile}.o] if { [build_executable_and_dwo_files "${testfile}.exp" ${testfile} {nodebu= g} \ [list $asm_file {nodebug split-dwo} ${object_file}] \ [list $srcfile {nodebug}]] } { - perror "failed to compile ${gdb_test_file_name}" return -1 }