From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id DEB07385040C; Wed, 12 Oct 2022 14:50:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEB07385040C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665586226; bh=MqFvm/T0jwksJEOJMwQhdUizDj4kOXXvkPhMcziny+M=; h=From:To:Subject:Date:From; b=Gej7ff7ZoCd1z3rHZBFPFdYFk2KcKOH+0HG2gnGRCbHscCqHy50m2R4QiMbTd8gJq VIuj9NYAXEbFMYnO5IGJFqPMq058U652MQCx6LY2/yL6Utl3EREpMjIa3G0T531wZo 62kR/k5VuGHvOcAQgwGjhMqO70nnouKeHa+NLw7c= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.base/nested-subp{2,3}.exp with recent ld X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: e2800454ce9d89f9c4587bc20ee7c6cd0122c340 X-Git-Newrev: 9693166f6648b3aaa7dc680b3fecda16b63ecfb4 Message-Id: <20221012145026.DEB07385040C@sourceware.org> Date: Wed, 12 Oct 2022 14:50:26 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D9693166f6648= b3aaa7dc680b3fecda16b63ecfb4 commit 9693166f6648b3aaa7dc680b3fecda16b63ecfb4 Author: Tom de Vries Date: Wed Oct 12 16:50:16 2022 +0200 [gdb/testsuite] Fix gdb.base/nested-subp{2,3}.exp with recent ld =20 On openSUSE Tumbleweed (with ld 2.39) I get for test-case gdb.base/nested-subp2.exp: ... gdb compile failed, ld: warning: tmp.o: requires executable stack \ (because the .note.GNU-stack section is executable) ... =20 Fix this by compiling with -Wl,--no-warn-execstack. =20 Likewise in gdb.base/nested-subp3.exp =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.base/nested-subp2.exp | 15 ++++++++++++--- gdb/testsuite/gdb.base/nested-subp3.exp | 15 ++++++++++++--- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.base/nested-subp2.exp b/gdb/testsuite/gdb.ba= se/nested-subp2.exp index efc8dc5c25b..7716e7c8ace 100644 --- a/gdb/testsuite/gdb.base/nested-subp2.exp +++ b/gdb/testsuite/gdb.base/nested-subp2.exp @@ -29,10 +29,19 @@ if ![support_nested_function_tests] { return -1 } =20 +set flags {} +lappend flags debug +lappend flags additional_flags=3D-std=3Dgnu99 + +set ld_flags additional_flags=3D-Wl,--no-warn-execstack +if { [gdb_can_simple_compile ld-flags {int main () { return 0; }} executab= le \ + $ld_flags] } { + lappend flags $ld_flags +} + if { [gdb_compile "${srcdir}/${subdir}/${testcase}.c" \ - [standard_output_file "${testcase}"] \ - executable \ - [list debug "additional_flags=3D-std=3Dgnu99"]] !=3D "" = } { + [standard_output_file "${testcase}"] \ + executable $flags] !=3D "" } { return -1 } =20 diff --git a/gdb/testsuite/gdb.base/nested-subp3.exp b/gdb/testsuite/gdb.ba= se/nested-subp3.exp index fc87631c342..b547b8efd35 100644 --- a/gdb/testsuite/gdb.base/nested-subp3.exp +++ b/gdb/testsuite/gdb.base/nested-subp3.exp @@ -29,10 +29,19 @@ if ![support_nested_function_tests] { return -1 } =20 +set flags {} +lappend flags debug +lappend flags additional_flags=3D-std=3Dgnu99 + +set ld_flags additional_flags=3D-Wl,--no-warn-execstack +if { [gdb_can_simple_compile ld-flags {int main () { return 0; }} executab= le \ + $ld_flags] } { + lappend flags $ld_flags +} + if { [gdb_compile "${srcdir}/${subdir}/${testcase}.c" \ - [standard_output_file "${testcase}"] \ - executable \ - [list debug "additional_flags=3D-std=3Dgnu99"]] !=3D "" = } { + [standard_output_file "${testcase}"] \ + executable $flags] !=3D "" } { return -1 }