From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 15BA9385800B; Fri, 14 Oct 2022 11:10:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15BA9385800B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665745829; bh=YWYFz27MCl9QFIrRT/gCWaCpfLSL1qtVECgXQr6jyDo=; h=From:To:Subject:Date:From; b=t+wXcldBTyQ/B5hefqyBO2ECFWtm0qtsWMhuX98/7MUPD9tQ9LDSo+fFX6ari+eSz JrhQ30RNzJUE+b0Ln2iLGSxLqiknM5INw5RSHxMyyssUoyMhM5n+Z0JJ0UhA+Ky1Xr WT9SQFo8BSEu6BYNJ4CzAbNWlHX3JOnSw9+GHOvE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: f98a7af815ce6f656eebe95e8dc21b63bb8ec9d2 X-Git-Newrev: b3a5b1fd71079ffb01b4969b34e11fd6c5d416f6 Message-Id: <20221014111029.15BA9385800B@sourceware.org> Date: Fri, 14 Oct 2022 11:10:29 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Db3a5b1fd7107= 9ffb01b4969b34e11fd6c5d416f6 commit b3a5b1fd71079ffb01b4969b34e11fd6c5d416f6 Author: Tom de Vries Date: Fri Oct 14 13:09:51 2022 +0200 [gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp =20 I noticed in gdb.base/skip-solib.exp: ... if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib= } \ [list debug -Wl,-soname,${libname}.so]] !=3D ""} { return -1 } ... that the -Wl,-soname argument is missing an ldflags=3D prefix, but addi= ng it gives us a duplicate: ... Executing on host: gcc -fno-stack-protector \ outputs/gdb.base/skip-solib/skip-solib-lib.c.o -fdiagnostics-color= =3Dnever \ -shared -g -Wl,-soname,libskip-solib.so -Wl,-soname,libskip-solib.so= -lm \ -o outputs/gdb.base/skip-solib/libskip-solib.so (timeout =3D 300) ... so apparently it's taken care of by gdb_compile_shlib. =20 Drop the inactive and also unnecessary -Wl,-soname,${libname}.so from t= he flags list for the gdb_compile_shlib call. =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.base/skip-solib.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base= /skip-solib.exp index 9af39d829c0..49539bb6695 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -41,7 +41,7 @@ set binfile_lib [standard_output_file ${libname}.so] # =20 if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \ - [list debug -Wl,-soname,${libname}.so]] !=3D ""} { + [list debug]] !=3D ""} { return -1 }