public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] More uses of checked_static_cast Date: Sun, 16 Oct 2022 18:17:37 +0000 (GMT) [thread overview] Message-ID: <20221016181737.ECFB83858413@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=da6f3d00b490caf570a8bda0bab1cd78388bb795 commit da6f3d00b490caf570a8bda0bab1cd78388bb795 Author: Tom Tromey <tom@tromey.com> Date: Sat Sep 24 13:38:42 2022 -0600 More uses of checked_static_cast This patch changes a few more uses of static_cast to use checked_static_cast. In this patch, cast-to-references are converted by moving the dereference outside of the cast, as checked_static_cast only handles pointers. Diff: --- gdb/dwarf2/read.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 3f71ebd1d66..e62f9752a80 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -3155,8 +3155,8 @@ dwarf2_gdb_index::expand_matching_symbols const block_enum block_kind = global ? GLOBAL_BLOCK : STATIC_BLOCK; mapped_index &index - = (static_cast<mapped_index &> - (*per_objfile->per_bfd->index_table.get ())); + = *(gdb::checked_static_cast<mapped_index *> + (per_objfile->per_bfd->index_table.get ())); const char *match_name = name.ada ().lookup_name ().c_str (); auto matcher = [&] (const char *symname) @@ -4005,8 +4005,8 @@ dw2_expand_marked_cus offset_type vec_len, vec_idx; bool global_seen = false; mapped_index &index - = (static_cast<mapped_index &> - (*per_objfile->per_bfd->index_table.get ())); + = *(gdb::checked_static_cast<mapped_index *> + (per_objfile->per_bfd->index_table.get ())); offset_view vec (index.constant_pool.slice (index.symbol_vec_index (idx))); vec_len = vec[0]; @@ -4225,8 +4225,8 @@ dwarf2_gdb_index::expand_symtabs_matching } mapped_index &index - = (static_cast<mapped_index &> - (*per_objfile->per_bfd->index_table.get ())); + = *(gdb::checked_static_cast<mapped_index *> + (per_objfile->per_bfd->index_table.get ())); bool result = dw2_expand_symtabs_matching_symbol (index, *lookup_name, @@ -5208,8 +5208,8 @@ dwarf2_debug_names_index::expand_matching_symbols dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile); mapped_debug_names &map - = (static_cast<mapped_debug_names &> - (*per_objfile->per_bfd->index_table.get ())); + = *(gdb::checked_static_cast<mapped_debug_names *> + (per_objfile->per_bfd->index_table.get ())); const block_search_flags block_flags = global ? SEARCH_GLOBAL_BLOCK : SEARCH_STATIC_BLOCK; @@ -5270,8 +5270,8 @@ dwarf2_debug_names_index::expand_symtabs_matching } mapped_debug_names &map - = (static_cast<mapped_debug_names &> - (*per_objfile->per_bfd->index_table.get ())); + = *(gdb::checked_static_cast<mapped_debug_names *> + (per_objfile->per_bfd->index_table.get ())); bool result = dw2_expand_symtabs_matching_symbol (map, *lookup_name,
reply other threads:[~2022-10-16 18:17 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221016181737.ECFB83858413@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).