From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1551) id 5B4AA3858D32; Mon, 17 Oct 2022 16:58:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B4AA3858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666025939; bh=XrYXVfmbF8ytLq0Imuz4Iqvyk3paL3tdvIidbqhGVug=; h=From:To:Subject:Date:From; b=TBCaDIHmWvosT5MjJi8vYqRGnkdhrwxKIR+Y6PO/yLjsGDfBsrwhUF6XLtEj7J120 ZjhGHJ8fklUN8M0uTprquj1vYadynH84d0hnjR85pcon0V9wDLgCe1bKMdDLmmk0la 2gbj7ZMA0OBaJL1NreR/+wu2O6z7ecPmvSw0/078= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pedro Alves To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdbarch-components.py: Remove spurious space from "frame_info_ptr " params X-Act-Checkin: binutils-gdb X-Git-Author: Pedro Alves X-Git-Refname: refs/heads/master X-Git-Oldrev: dd05fc7071a6517de13975fcddca861547351266 X-Git-Newrev: 39e9d8670cea9d3d2959387b6d51050b0716eb19 Message-Id: <20221017165859.5B4AA3858D32@sourceware.org> Date: Mon, 17 Oct 2022 16:58:59 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D39e9d8670cea= 9d3d2959387b6d51050b0716eb19 commit 39e9d8670cea9d3d2959387b6d51050b0716eb19 Author: Pedro Alves Date: Mon Oct 17 17:48:35 2022 +0100 gdbarch-components.py: Remove spurious space from "frame_info_ptr " par= ams =20 If you run gdbarch.py today, you'll get local modifications compared to what's in the tree, like: =20 --- c/gdb/gdbarch-gen.h +++ w/gdb/gdbarch-gen.h @@ -315,8 +315,8 @@ extern void set_gdbarch_register_type (struct gdba= rch *gdbarch, gdbarch_register should match the address at which the breakpoint was set in the du= mmy frame. */ =20 -typedef struct frame_id (gdbarch_dummy_id_ftype) (struct gdbarch *gdb= arch, frame_info_ptr this_frame); -extern struct frame_id gdbarch_dummy_id (struct gdbarch *gdbarch, fra= me_info_ptr this_frame); +typedef struct frame_id (gdbarch_dummy_id_ftype) (struct gdbarch *gdb= arch, frame_info_ptr this_frame); +extern struct frame_id gdbarch_dummy_id (struct gdbarch *gdbarch, fra= me_info_ptr this_frame); extern void set_gdbarch_dummy_id (struct gdbarch *gdbarch, gdbarch_du= mmy_id_ftype *dummy_id); =20 etc. =20 The extra space comes from the "frame_info_ptr " param that appears in a number of gdbarch methods in gdbarch-components.py. With the extra space removed, running ./gdbarch.py generates the exact code that's in the tree already. =20 Change-Id: If7d20b8c6b2fd9ff466142a01bd2611c9ef9f53e Diff: --- gdb/gdbarch-components.py | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/gdb/gdbarch-components.py b/gdb/gdbarch-components.py index ba16f4a6a1a..46e7565f293 100644 --- a/gdb/gdbarch-components.py +++ b/gdb/gdbarch-components.py @@ -613,7 +613,7 @@ frame. """, type=3D"struct frame_id", name=3D"dummy_id", - params=3D[("frame_info_ptr ", "this_frame")], + params=3D[("frame_info_ptr", "this_frame")], predefault=3D"default_dummy_id", invalid=3DFalse, ) @@ -676,7 +676,7 @@ Return true if the code of FRAME is writable. """, type=3D"int", name=3D"code_of_frame_writable", - params=3D[("frame_info_ptr ", "frame")], + params=3D[("frame_info_ptr", "frame")], predefault=3D"default_code_of_frame_writable", invalid=3DFalse, ) @@ -686,7 +686,7 @@ Method( name=3D"print_registers_info", params=3D[ ("struct ui_file *", "file"), - ("frame_info_ptr ", "frame"), + ("frame_info_ptr", "frame"), ("int", "regnum"), ("int", "all"), ], @@ -699,7 +699,7 @@ Method( name=3D"print_float_info", params=3D[ ("struct ui_file *", "file"), - ("frame_info_ptr ", "frame"), + ("frame_info_ptr", "frame"), ("const char *", "args"), ], predefault=3D"default_print_float_info", @@ -711,7 +711,7 @@ Method( name=3D"print_vector_info", params=3D[ ("struct ui_file *", "file"), - ("frame_info_ptr ", "frame"), + ("frame_info_ptr", "frame"), ("const char *", "args"), ], predicate=3DTrue, @@ -755,7 +755,7 @@ FRAME corresponds to the longjmp frame. """, type=3D"int", name=3D"get_longjmp_target", - params=3D[("frame_info_ptr ", "frame"), ("CORE_ADDR *", "pc")], + params=3D[("frame_info_ptr", "frame"), ("CORE_ADDR *", "pc")], predicate=3DTrue, invalid=3DTrue, ) @@ -778,7 +778,7 @@ Function( type=3D"int", name=3D"register_to_value", params=3D[ - ("frame_info_ptr ", "frame"), + ("frame_info_ptr", "frame"), ("int", "regnum"), ("struct type *", "type"), ("gdb_byte *", "buf"), @@ -792,7 +792,7 @@ Function( type=3D"void", name=3D"value_to_register", params=3D[ - ("frame_info_ptr ", "frame"), + ("frame_info_ptr", "frame"), ("int", "regnum"), ("struct type *", "type"), ("const gdb_byte *", "buf"), @@ -1065,7 +1065,7 @@ Value( Method( type=3D"CORE_ADDR", name=3D"unwind_pc", - params=3D[("frame_info_ptr ", "next_frame")], + params=3D[("frame_info_ptr", "next_frame")], predefault=3D"default_unwind_pc", invalid=3DFalse, ) @@ -1073,7 +1073,7 @@ Method( Method( type=3D"CORE_ADDR", name=3D"unwind_sp", - params=3D[("frame_info_ptr ", "next_frame")], + params=3D[("frame_info_ptr", "next_frame")], predefault=3D"default_unwind_sp", invalid=3DFalse, ) @@ -1085,7 +1085,7 @@ frame-base. Enable frame-base before frame-unwind. """, type=3D"int", name=3D"frame_num_args", - params=3D[("frame_info_ptr ", "frame")], + params=3D[("frame_info_ptr", "frame")], predicate=3DTrue, invalid=3DTrue, ) @@ -1260,7 +1260,7 @@ further single-step is needed before the instruction = finishes. """, type=3D"int", name=3D"single_step_through_delay", - params=3D[("frame_info_ptr ", "frame")], + params=3D[("frame_info_ptr", "frame")], predicate=3DTrue, invalid=3DTrue, ) @@ -1280,7 +1280,7 @@ disassembler. Perhaps objdump can handle it? Function( type=3D"CORE_ADDR", name=3D"skip_trampoline_code", - params=3D[("frame_info_ptr ", "frame"), ("CORE_ADDR", "pc")], + params=3D[("frame_info_ptr", "frame"), ("CORE_ADDR", "pc")], predefault=3D"generic_skip_trampoline_code", invalid=3DFalse, ) @@ -1503,7 +1503,7 @@ Fetch the pointer to the ith function argument. type=3D"CORE_ADDR", name=3D"fetch_pointer_argument", params=3D[ - ("frame_info_ptr ", "frame"), + ("frame_info_ptr", "frame"), ("int", "argi"), ("struct type *", "type"), ], @@ -2664,7 +2664,7 @@ Return a string containing any flags for the given PC= in the given FRAME. """, type=3D"std::string", name=3D"get_pc_address_flags", - params=3D[("frame_info_ptr ", "frame"), ("CORE_ADDR", "pc")], + params=3D[("frame_info_ptr", "frame"), ("CORE_ADDR", "pc")], predefault=3D"default_get_pc_address_flags", invalid=3DFalse, )