From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 802803858D32; Tue, 18 Oct 2022 16:33:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 802803858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666110800; bh=GOxGYRSGyfogNpKtiwCHOWcnzwboaSsQEd2Hkzh/940=; h=From:To:Subject:Date:From; b=siRWOX1sFQUwmjWrWjfvS9MJu/gi7vfBPhb10rxfW3jU9IcrmmPG7pLl0/pvMMCns x3GXMnsm7msyEQuYbpmgECVhX6Ry7p3UDvoJ5QWHYobcSxCvxa228cfjZ++3CueNyf 8Zxo9YQICx4sdN1jDdFE4CJFNk4axBdmNfbWSEOY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove dead code from py-finishbreakpoint.c X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: f760c4f2999946dcc4936873a89cf2c24edc5e9b X-Git-Newrev: 04ea6b63141c43d9e96999e16917358088556fdd Message-Id: <20221018163320.802803858D32@sourceware.org> Date: Tue, 18 Oct 2022 16:33:20 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D04ea6b63141c= 43d9e96999e16917358088556fdd commit 04ea6b63141c43d9e96999e16917358088556fdd Author: Tom Tromey Date: Sun Jun 5 10:22:40 2022 -0600 Remove dead code from py-finishbreakpoint.c =20 PR python/16324 points out that comparing a frame id to null_frame_id can never succeed, and proposes simply removing the dead code. That is what this patch does. =20 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D16324 Diff: --- gdb/python/py-finishbreakpoint.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpo= int.c index 1d25cca5c17..0255bd1fead 100644 --- a/gdb/python/py-finishbreakpoint.c +++ b/gdb/python/py-finishbreakpoint.c @@ -205,12 +205,7 @@ bpfinishpy_init (PyObject *self, PyObject *args, PyObj= ect *kwargs) "be set on a dummy frame.")); } else - { - frame_id =3D get_frame_id (prev_frame); - if (frame_id =3D=3D null_frame_id) - PyErr_SetString (PyExc_ValueError, - _("Invalid ID for the `frame' object.")); - } + frame_id =3D get_frame_id (prev_frame); } } catch (const gdb_exception &except)