[binutils-gdb] sim/ppc: mark device_error function as ATTRIBUTE_NORETURN

[binutils-gdb] sim/ppc: mark device_error function as ATTRIBUTE_NORETURN

[Andrew Burgess]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e5961d2be503149aaa40927c0a9501c06ca980e5

commit e5961d2be503149aaa40927c0a9501c06ca980e5
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Wed Oct 12 11:14:26 2022 +0100

    sim/ppc: mark device_error function as ATTRIBUTE_NORETURN
    
    The device_error function always ends up calling the error function,
    which is itself marked as ATTRIBUTE_NORETURN, so it makes sense that
    device_error should also be marked ATTRIBUTE_NORETURN.
    
    Doing this resolves a few warnings from hw_ide.c about possibly
    uninitialized variables - the variables are only uninitialized after
    passing through a call to device_error, which obviously means the
    variables are never really used uninitialized, the simulation will
    terminate with the device_error call.

Diff:
---
 sim/ppc/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/ppc/device.h b/sim/ppc/device.h
index bd539095160..65c85e4ddd3 100644
--- a/sim/ppc/device.h
+++ b/sim/ppc/device.h
@@ -729,7 +729,7 @@ EXTERN_DEVICE\
 (void) device_error
 (device *me,
  const char *fmt,
- ...) ATTRIBUTE_PRINTF_2;
+ ...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF_2;
 
 INLINE_DEVICE\
 (int) device_trace