public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb] Fix assert in handle_jit_event
Date: Wed, 19 Oct 2022 15:41:53 +0000 (GMT)	[thread overview]
Message-ID: <20221019154154.D65043858D3C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=508ccf9b3e1db355037a4a1c9004efe0d6d3ffbf

commit 508ccf9b3e1db355037a4a1c9004efe0d6d3ffbf
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Oct 19 17:41:47 2022 +0200

    [gdb] Fix assert in handle_jit_event
    
    With the cc-with-tweaks.sh patch submitted here (
    https://sourceware.org/pipermail/gdb-patches/2022-October/192586.html ) we run
    with:
    ...
    $ export STRIP_ARGS_STRIP_DEBUG=--strip-all
    $ make check RUNTESTFLAGS="gdb.base/jit-reader.exp \
        --target_board cc-with-gnu-debuglink"
    ...
    into the following assert:
    ...
    (gdb) run ^M
    Starting program: jit-reader ^M
    gdb/jit.c:1247: internal-error: jit_event_handler: \
      Assertion `jiter->jiter_data != nullptr' failed.^M
    ...
    
    Fix this by handling the
    jit_bp_sym.objfile->separate_debug_objfile_backlink != nullptr case in
    handle_jit_event.
    
    Tested on x86_64-linux.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29277

Diff:
---
 gdb/breakpoint.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index eb4dedf3f10..0eace4f9f03 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5679,7 +5679,10 @@ handle_jit_event (CORE_ADDR address)
      function needs to be updated too.  */
   bound_minimal_symbol jit_bp_sym = lookup_minimal_symbol_by_pc (address);
   gdb_assert (jit_bp_sym.objfile != nullptr);
-  jit_event_handler (gdbarch, jit_bp_sym.objfile);
+  objfile *objfile = jit_bp_sym.objfile;
+  if (objfile->separate_debug_objfile_backlink)
+    objfile = objfile->separate_debug_objfile_backlink;
+  jit_event_handler (gdbarch, objfile);
 
   target_terminal::inferior ();
 }

                 reply	other threads:[~2022-10-19 15:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019154154.D65043858D3C@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).