public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org
Subject: [binutils-gdb] Reapply "Don't build readline/libreadline.a, when --with-system-readline is supplied"
Date: Thu, 20 Oct 2022 15:05:08 +0000 (GMT)	[thread overview]
Message-ID: <20221020150508.188983850205@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1c232ab030476db2037894600ef5eba9a6de5645

commit 1c232ab030476db2037894600ef5eba9a6de5645
Author: Дилян Палаузов <dilyan.palauzov@aegee.org>
Date:   Thu Oct 20 17:05:04 2022 +0200

    Reapply "Don't build readline/libreadline.a, when --with-system-readline is supplied"
    
    Commit 228cf97dd3c8 ("Merge configure.ac from gcc project") undid the
    change originally done in commit 69961a84c9b ("Don't build
    readline/libreadline.a, when --with-system-readline is supplied").
    Re-apply it.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18632

Diff:
---
 configure    | 6 ++++++
 configure.ac | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/configure b/configure
index 9ea8034f5d7..7bcb894d1fe 100755
--- a/configure
+++ b/configure
@@ -2960,6 +2960,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 
 # Check whether --with-zstd was given.
 if test "${with_zstd+set}" = set; then :
diff --git a/configure.ac b/configure.ac
index 8af83cc98d3..aab451467bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -248,6 +248,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 AC_ARG_WITH(zstd,
 [AS_HELP_STRING([--with-zstd], [Support zstd compressed debug sections (default=auto)])])

                 reply	other threads:[~2022-10-20 15:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020150508.188983850205@sourceware.org \
    --to=vries@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).