From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 7A6A33851533; Thu, 27 Oct 2022 15:14:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A6A33851533 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666883679; bh=fpstYCKO7yzsvYST8PgYV3hMkXefZn4kL8szF7gb7yw=; h=From:To:Subject:Date:From; b=BUL9+IHvbboagILzdK381K2cqmJlDfuWL/ojjhtAYiocFz2SsAqk18+bS6tBpun/U vFuot/acvFi67WRWodHT2lhMRCbe5d5exV3deU1oAqevlY9EpGjNX+bkV/5wDZfmI5 wWKOs47qCXy1V9w4scyAKZVGT8V4lvv1TweeuVsE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Remove address from test names X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: 1dc83674da675a20ae361a037305777d23764574 X-Git-Newrev: 48ca5676924d2609f1b9ea1990719c9eb41e88a2 Message-Id: <20221027151439.7A6A33851533@sourceware.org> Date: Thu, 27 Oct 2022 15:14:38 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D48ca5676924d= 2609f1b9ea1990719c9eb41e88a2 commit 48ca5676924d2609f1b9ea1990719c9eb41e88a2 Author: Tom de Vries Date: Thu Oct 27 17:14:33 2022 +0200 [gdb/testsuite] Remove address from test names =20 I noticed an address in a test name: ... PASS: gdb.base/eh_return.exp: gdb_breakpoint: \ set breakpoint at *0x000000000040071b ... =20 Stabilize the test name by using "set breakpoint on address" instead. =20 Likewise in two other test-cases. =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.base/eh_return.exp | 2 +- gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp | 2 +- gdb/testsuite/gdb.opt/inline-break.exp | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/eh_return.exp b/gdb/testsuite/gdb.base/= eh_return.exp index 6e4b9bd0bba..a6dda78e013 100644 --- a/gdb/testsuite/gdb.base/eh_return.exp +++ b/gdb/testsuite/gdb.base/eh_return.exp @@ -73,7 +73,7 @@ if { $address =3D=3D -1 } { =20 clean_restart ${binfile} =20 -gdb_breakpoint "*$address" message +gdb_assert [gdb_breakpoint "*$address" no-message] "set breakpoint on addr= ess" =20 # The assert did not reproduce when running to main, and continuing to the # breakpoint, so instead, run to the breakpoint. diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp b/gdb/testsuite/g= db.base/sss-bp-on-user-bp.exp index 17537585ad2..2e479d6ebe2 100644 --- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp +++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp @@ -45,7 +45,7 @@ if { $next_insn_addr =3D=3D "" } { return -1 } =20 -gdb_test "b *$next_insn_addr" "Breakpoint .*" +gdb_test "b *$next_insn_addr" "Breakpoint .*" "set breakpoint on address" =20 # So that GDB doesn't try to remove the regular breakpoint when the # step finishes. diff --git a/gdb/testsuite/gdb.opt/inline-break.exp b/gdb/testsuite/gdb.opt= /inline-break.exp index 24dd6ebaf0a..708fd74aa1e 100644 --- a/gdb/testsuite/gdb.opt/inline-break.exp +++ b/gdb/testsuite/gdb.opt/inline-break.exp @@ -292,7 +292,9 @@ with_test_prefix "address" { =20 # Set the breakpoint by address, and check that GDB reports the # breakpoint location being the inline function. - gdb_test "break *$address" ".*Breakpoint .* at $address: file .*$srcfi= le, line $line." + gdb_test "break *$address" \ + ".*Breakpoint .* at $address: file .*$srcfile, line $line." \ + "set breakpoint on address" =20 gdb_test "info break \$bpnum" "in func1 at .*$srcfile:$line"