public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fix Cygwin build after bcb9251f
Date: Wed,  2 Nov 2022 14:37:29 +0000 (GMT)	[thread overview]
Message-ID: <20221102143729.B0C523858D3C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=559a5ea452455d95ff18736ce6dfa9065427f74e

commit 559a5ea452455d95ff18736ce6dfa9065427f74e
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Sun Jun 12 16:39:46 2022 +0100

    Fix Cygwin build after bcb9251f
    
    Absent _UNICODE being defined (which gdb's Makefile doesn't do),
    windows.h will always define STARTUPINFO is as STARTUPINFOA, so this
    cast isn't correct when create_process expects a STARTUPINFOW
    parameter (i.e. in a Cygwin build).
    
    Instead write this as &info_ex.StartupInfo (which is always of the
    correct type).

Diff:
---
 gdb/nat/windows-nat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/nat/windows-nat.c b/gdb/nat/windows-nat.c
index ba60b585e85..42031d4757c 100644
--- a/gdb/nat/windows-nat.c
+++ b/gdb/nat/windows-nat.c
@@ -831,7 +831,7 @@ create_process_wrapper (FUNC *do_create_process, const CHAR *image,
 						| EXTENDED_STARTUPINFO_PRESENT),
 					       environment,
 					       cur_dir,
-					       (STARTUPINFO *) &info_ex,
+					       &info_ex.StartupInfo,
 					       process_info);
 	      if (result)
 		return_value = result;

                 reply	other threads:[~2022-11-02 14:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102143729.B0C523858D3C@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).