From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 644EB3858407; Sat, 5 Nov 2022 23:14:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 644EB3858407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667690087; bh=SU+jMPIUXdFLb6t2mWwgS4weMgE9x6rwICBRl9MIdtk=; h=From:To:Subject:Date:From; b=a8D2jsYYXNYqn4xp9rBm7RtdWvcqegKoP4VdkscmK6gXk+HpLwAtwEJpI9vhRHGLA Png468g+vaglLV6hvKKYhrTCLCmgqRgfr1Pb4olnVcUgwqqHDMd1F4qPEdZ3aR/7AJ oSGoVbtHMacPbJHSlltH1ysefj1JQhNCFWGe5mEM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Deprecate MI version 1 X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 5a9886170b3bc9027ec72ab425fb0e3d4a1aa330 X-Git-Newrev: 560f8d05a1d6b09305bac8e992c1a95367e9778e Message-Id: <20221105231447.644EB3858407@sourceware.org> Date: Sat, 5 Nov 2022 23:14:47 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D560f8d05a1d6= b09305bac8e992c1a95367e9778e commit 560f8d05a1d6b09305bac8e992c1a95367e9778e Author: Tom Tromey Date: Wed Sep 21 10:46:51 2022 -0600 Deprecate MI version 1 =20 MI version 1 is long since obsolete. Rather than remove it immediately (though I did send a patch for that), instead let's deprecate it in GDB 13 and then remove it for GDB 14. =20 This version of the patch incorporates Simon's warning change, and Luis' recommendation to mention the gdb versions here. Diff: --- gdb/NEWS | 2 ++ gdb/interps.c | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/gdb/NEWS b/gdb/NEWS index 8b519a648f7..0642d7637b8 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,8 @@ =20 *** Changes since GDB 12 =20 +* MI version 1 is deprecated, and will be removed in GDB 14. + * GDB now supports dumping memory tag data for AArch64 MTE. It also suppo= rts reading memory tag data for AArch64 MTE from core files generated by the gcore command or the Linux kernel. diff --git a/gdb/interps.c b/gdb/interps.c index a8bd67258e4..56d47906770 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -170,11 +170,16 @@ interp_set (struct interp *interp, bool top_level) if (interpreter_p !=3D interp->name ()) interpreter_p =3D interp->name (); =20 + bool warn_about_mi1 =3D false; + /* Run the init proc. */ if (!interp->inited) { interp->init (top_level); interp->inited =3D true; + + if (streq (interp->name (), "mi1")) + warn_about_mi1 =3D true; } =20 /* Do this only after the interpreter is initialized. */ @@ -184,6 +189,11 @@ interp_set (struct interp *interp, bool top_level) clear_interpreter_hooks (); =20 interp->resume (); + + if (warn_about_mi1) + warning (_("MI version 1 is deprecated in GDB 13 and " + "will be removed in GDB 14. Please upgrade " + "to a newer version of MI.")); } =20 /* Look up the interpreter for NAME. If no such interpreter exists,