public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] sim: ppc: add missing parens with e500 macro
Date: Wed, 9 Nov 2022 15:35:07 +0000 (GMT) [thread overview]
Message-ID: <20221109153507.433333858024@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c2264c8f78f353daebce3086ae52b3c1cf2f0a8d
commit c2264c8f78f353daebce3086ae52b3c1cf2f0a8d
Author: Mike Frysinger <vapier@gentoo.org>
Date: Wed Nov 9 22:33:27 2022 +0700
sim: ppc: add missing parens with e500 macro
This macro expansion was missing a set of outer-most parenthesis which
some compilers would complain about depending on how the macro is used.
This is just standard good macro hygiene too.
Diff:
---
sim/ppc/e500_expression.h | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/sim/ppc/e500_expression.h b/sim/ppc/e500_expression.h
index 1a27bb189e8..86d033ae66f 100644
--- a/sim/ppc/e500_expression.h
+++ b/sim/ppc/e500_expression.h
@@ -68,22 +68,22 @@
/* bit manipulation macros needed for e500 SPE */
#define EV_BITREVERSE16(x) \
- (((x) & 0x0001) << 15) \
- | (((x) & 0x0002) << 13) \
- | (((x) & 0x0004) << 11) \
- | (((x) & 0x0008) << 9) \
- | (((x) & 0x0010) << 7) \
- | (((x) & 0x0020) << 5) \
- | (((x) & 0x0040) << 3) \
- | (((x) & 0x0080) << 1) \
- | (((x) & 0x0100) >> 1) \
- | (((x) & 0x0200) >> 3) \
- | (((x) & 0x0400) >> 5) \
- | (((x) & 0x0800) >> 7) \
- | (((x) & 0x1000) >> 9) \
- | (((x) & 0x2000) >> 11) \
- | (((x) & 0x4000) >> 13) \
- | (((x) & 0x8000) >> 15)
+ ((((x) & 0x0001) << 15) \
+ | (((x) & 0x0002) << 13) \
+ | (((x) & 0x0004) << 11) \
+ | (((x) & 0x0008) << 9) \
+ | (((x) & 0x0010) << 7) \
+ | (((x) & 0x0020) << 5) \
+ | (((x) & 0x0040) << 3) \
+ | (((x) & 0x0080) << 1) \
+ | (((x) & 0x0100) >> 1) \
+ | (((x) & 0x0200) >> 3) \
+ | (((x) & 0x0400) >> 5) \
+ | (((x) & 0x0800) >> 7) \
+ | (((x) & 0x1000) >> 9) \
+ | (((x) & 0x2000) >> 11) \
+ | (((x) & 0x4000) >> 13) \
+ | (((x) & 0x8000) >> 15))
/* saturation helpers */
#define EV_MUL16_SSF(a,b) ((int64_t)((int32_t)(int16_t)(a) * (int32_t)(int16_t)(b)) << 1)
reply other threads:[~2022-11-09 15:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109153507.433333858024@sourceware.org \
--to=vapier@sourceware.org \
--cc=gdb-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).