public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: add missing prepare_reinflate call in print_frame_info
Date: Thu, 10 Nov 2022 16:34:16 +0000 (GMT)	[thread overview]
Message-ID: <20221110163416.1AFD03858425@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aeba2026b58a8abfc35c390f07bcdaf42728e7b5

commit aeba2026b58a8abfc35c390f07bcdaf42728e7b5
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Oct 21 11:49:44 2022 -0400

    gdb: add missing prepare_reinflate call in print_frame_info
    
    print_frame_info calls frame_info_ptr::reinflate, but not
    frame_info_ptr::prepare_reinflate, add the call to prepare_reinflate.
    It works right now, because all callers of print_frame_info that could
    possibly lead to the pretty printers being called, and the frame_info
    objects being invalidated, do call prepare_reinflate themselves.  And
    since the cached frame id is copied when passing a frame_info_ptr by
    value, print_frame_info does have a cached frame id on entry.  So
    technically, this change isn't needed.  But I don't think it's good for
    a function to rely on its callers to have called prepare_reinflate, if
    it intends to call reinflate.
    
    Change-Id: Ie332b2d5479aef46f83fdc1120c7c83f4e84d1b0
    Reviewed-By: Bruno Larsen <blarsen@redhat.com>

Diff:
---
 gdb/stack.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/stack.c b/gdb/stack.c
index 5f29566fcfe..4ad51c2eb50 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -1047,6 +1047,8 @@ print_frame_info (const frame_print_options &fp_opts,
   int location_print;
   struct ui_out *uiout = current_uiout;
 
+  frame.prepare_reinflate ();
+
   if (!current_uiout->is_mi_like_p ()
       && fp_opts.print_frame_info != print_frame_info_auto)
     {

                 reply	other threads:[~2022-11-10 16:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110163416.1AFD03858425@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).