public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] sim: igen: fix hang when decoding boolean rule constants
Date: Thu, 10 Nov 2022 18:41:55 +0000 (GMT)	[thread overview]
Message-ID: <20221110184156.51DD73858033@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ef7c5fd15dbe0937a2b5c729d88263beec507b42

commit ef7c5fd15dbe0937a2b5c729d88263beec507b42
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Fri Nov 11 01:35:42 2022 +0700

    sim: igen: fix hang when decoding boolean rule constants
    
    The parser for boolean rules fails to skip over the , separator in
    the options which makes it hang forever.  No dc files in the tree
    use boolean rules atm which is why no one noticed.

Diff:
---
 sim/igen/ld-decode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sim/igen/ld-decode.c b/sim/igen/ld-decode.c
index d1c90463ca3..51bb3e0b0a3 100644
--- a/sim/igen/ld-decode.c
+++ b/sim/igen/ld-decode.c
@@ -131,6 +131,8 @@ load_decode_table (const char *file_name)
 		  break;
 		}
 	      chp = skip_to_separator (chp, ",");
+	      if (*chp == ',')
+		++chp;
 	      chp = skip_spaces (chp);
 	    }
 	}

                 reply	other threads:[~2022-11-10 18:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110184156.51DD73858033@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).