From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7862) id 0A8623858D3C; Fri, 11 Nov 2022 09:17:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A8623858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668158263; bh=zxXxWRlFF2yR5mhfAZA0oEzk/XZP5lFEBPWHRQ9jHcg=; h=From:To:Subject:Date:From; b=scv03Bsh9cXWN7LkjoE9HOmGBZj121azr9uxB0kxSwlitiDx/ZCRL9SgC3ghUQpei Zb+ooLScOOCzWMEfOdk7MjaESQoLsOjcx9ep57Rx8AYTidbI+lWvfNJz84NUBTmD5w nOZLIBprxHXE5H/pwCyabKDt/wZhCq2NiUYyTVfY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Bruno Larsen To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp X-Act-Checkin: binutils-gdb X-Git-Author: Bruno Larsen X-Git-Refname: refs/heads/master X-Git-Oldrev: ebe9ddbce72cb50e8d18663feafd48a7b172fab9 X-Git-Newrev: 2604c0dc3b89dcf7114de4ce71b7556bf4bf6913 Message-Id: <20221111091743.0A8623858D3C@sourceware.org> Date: Fri, 11 Nov 2022 09:17:43 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D2604c0dc3b89= dcf7114de4ce71b7556bf4bf6913 commit 2604c0dc3b89dcf7114de4ce71b7556bf4bf6913 Author: Bruno Larsen Date: Tue Oct 4 19:07:46 2022 +0200 gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp =20 gdb.cp/temargs.exp last 2 tests always setup an XFAILs, despite checking for old gcc versions. However, Clang does not fail in this test, turning into XPASSes and slighty annoying when comparing between compilers. To change this, make the xfails only happen if we using gcc. =20 Approved-by: Tom Tromey Diff: --- gdb/testsuite/gdb.cp/temargs.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.cp/temargs.exp b/gdb/testsuite/gdb.cp/temarg= s.exp index 05fd902bb83..22c29cc7d8a 100644 --- a/gdb/testsuite/gdb.cp/temargs.exp +++ b/gdb/testsuite/gdb.cp/temargs.exp @@ -46,6 +46,8 @@ if {[test_compiler_info {gcc-[0-3]-*}] set have_pr_45024_fixed 0 } =20 +set using_gcc [test_compiler_info gcc-*-*] + set line [gdb_get_line_number "Breakpoint 1" $srcfile] gdb_test "break $srcfile:$line" "Breakpoint 2.*" \ "set first breakpoint for temargs" @@ -190,10 +192,10 @@ gdb_test "print F" "&S::somefunc" "test value of F in= k2_m" gdb_continue_to_breakpoint "continue to sixth breakpoint for temargs" =20 if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_xfail gcc/49546 "*-*-*" } +} elseif { $using_gcc } { setup_xfail gcc/49546 "*-*-*" } gdb_test "ptype F" {type =3D void \(\*\)\(int\)} "test type of F in k3_m" =20 if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_xfail gcc/49546 "*-*-*" } +} elseif { $using_gcc } { setup_xfail gcc/49546 "*-*-*" } gdb_test "print F" { =3D \(void \(\*\)\(int\)\) 0x[0-9a-f]+ = } \ "test value of F in k3_m"