public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Don't timeout on prompt in gdb_start_cmd
Date: Fri, 11 Nov 2022 14:52:13 +0000 (GMT)	[thread overview]
Message-ID: <20221111145213.3BBC63858D20@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ac42aa228f3f1ebda16ddb53b993d6341dbbf100

commit ac42aa228f3f1ebda16ddb53b993d6341dbbf100
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Nov 11 15:52:10 2022 +0100

    [gdb/testsuite] Don't timeout on prompt in gdb_start_cmd
    
    We're currently running into a timeout at:
    ...
    (gdb) start ^M
    Error in expression, near `1'.^M
    (gdb) UNTESTED: gdb.ada/start.exp: start failed to land inside the right \
      procedure
    ...
    due to the fact that gdb_start_cmd doesn't handle a prompt as reaction to
    the start command.
    
    Fix this by handling the prompt.  Reduces execution time of the test-case from
    1m1s to 1s.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/lib/gdb.exp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index d70b6410441..1240c2ef6f3 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -548,6 +548,7 @@ proc gdb_start_cmd { {inferior_args {}} } {
 	-notransfer -re "Starting program: \[^\r\n\]*" {
 	    return 0
 	}
+	-re "$gdb_prompt $" { }
     }
     return -1
 }

                 reply	other threads:[~2022-11-11 14:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221111145213.3BBC63858D20@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).