From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id D7BD13894C20; Tue, 15 Nov 2022 13:00:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7BD13894C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668517244; bh=uwryEQ2QUVx3JOkpVlW2dajzZOSk2/6UAR/NWl6OoIQ=; h=From:To:Subject:Date:From; b=Aa+fPQsRU1h7y/slVIB/FCcx1SDM7+EWfcgEc/BJDXyVmxUMOA/Cy9G7XIWjLfi7J spDYItJaZpSFn8/kZCv2j8tosHRTHKSDn0vY+yBzhvtRjXzVE8lt3Pn9mrpyzuL7IY iqtoNaPHh0BQ8YK3U2T/mqB6hxx7ahTbrNau5sDs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testssuite] Skip aarch64 in skip_gdbserver_test if no xml support X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: c7d0901842fc1b4391e1d7663608b7b43edd9fde X-Git-Newrev: 08d237dd4ebdcc0a13cac1dc57cd73de067d2f98 Message-Id: <20221115130044.D7BD13894C20@sourceware.org> Date: Tue, 15 Nov 2022 13:00:44 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D08d237dd4ebd= cc0a13cac1dc57cd73de067d2f98 commit 08d237dd4ebdcc0a13cac1dc57cd73de067d2f98 Author: Tom de Vries Date: Tue Nov 15 14:00:41 2022 +0100 [gdb/testssuite] Skip aarch64 in skip_gdbserver_test if no xml support =20 On aarch64-linux, with a gdb build without libexpat, so without xml sup= port, I run into: ... (gdb) builtin_spawn attach-no-multi-process^M attach 26808^M Attaching to Remote target^M warning: Can not parse XML target description; XML support was disabled= at \ compile time^M Reading symbols from attach-no-multi-process...^M Remote 'g' packet reply is too long (expected 788 bytes, got 796 bytes)= : ... ^M ... =20 The test-case checks for skip_gdbserver_tests and that one contains a c= heck for xml support: ... # If GDB is lack of XML support, and targets, like arm, have # multiple target descriptions, GDB doesn't know which target # description GDBserver uses, and may fail to parse 'g' packet # after connection. if { [gdb_skip_xml_test] && ([istarget "arm*-*-linux*"] || [istarget "mips*-*-linux*"] || [istarget "powerpc*-*-linux*"] || [istarget "s390*-*-linux*"] || [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"]) } { return 1 } ... but it doesn't trigger because aarch64 is missing. =20 Fix this by adding istarget "aarch64*-*-linux*". =20 Tested on aarch64-linux. =20 Approved-By: Luis Machado Diff: --- gdb/testsuite/lib/gdbserver-support.exp | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gd= bserver-support.exp index 3f2cec246fa..c9f0c35c07e 100644 --- a/gdb/testsuite/lib/gdbserver-support.exp +++ b/gdb/testsuite/lib/gdbserver-support.exp @@ -173,6 +173,7 @@ proc skip_gdbserver_tests { } { # after connection. if { [gdb_skip_xml_test] && ([istarget "arm*-*-linux*"] + || [istarget "aarch64*-*-linux*"] || [istarget "mips*-*-linux*"] || [istarget "powerpc*-*-linux*"] || [istarget "s390*-*-linux*"]