From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vries@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2205)
	id BF7F13895FFD; Tue, 15 Nov 2022 14:25:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF7F13895FFD
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1668522330;
	bh=Ma3OaPNthmtW0j/TxnXNwmito1gUAjqQuwwNhgnLG28=;
	h=From:To:Subject:Date:From;
	b=Su+1CmyI5Lir3ozesxvGbWAG13wEqVdHUu6jS8PaV60a43qDWj7xpURT6mphfkOMV
	 KNg5qQ9vP4H2S8folobzk5hF8DEaqukx38kWcxSyX72rkVDzBSbQ+U2sR6pJrjqJeL
	 WenIJbgz6f+ikHVI2kMkVPrZfKBDRwlderL6BRIk=
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.base/info-shared.exp for remote target
X-Act-Checkin: binutils-gdb
X-Git-Author: Tom de Vries <tdevries@suse.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: a1dfb76d919d45276963f2be35e8a235937d9d8f
X-Git-Newrev: e27e0e5d4147af715d479fda7583d74cf6a17266
Message-Id: <20221115142530.BF7F13895FFD@sourceware.org>
Date: Tue, 15 Nov 2022 14:25:30 +0000 (GMT)
List-Id: <gdb-cvs.sourceware.org>

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3De27e0e5d4147=
af715d479fda7583d74cf6a17266

commit e27e0e5d4147af715d479fda7583d74cf6a17266
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Nov 15 15:24:54 2022 +0100

    [gdb/testsuite] Fix gdb.base/info-shared.exp for remote target
   =20
    With test-case gdb.base/info-shared.exp and target board
    remote-gdbserver-on-localhost (using REMOTE_TARGET_USERNAME) we run int=
o some
    failures.
   =20
    Fix these by adding the missing gdb_load_shlib.
   =20
    Tested on x86_64-linux.
   =20
    Co-Authored-by: Ivan Tetyushkin <ivan.tetyushkin@syntacore.com>

Diff:
---
 gdb/testsuite/gdb.base/info-shared.exp | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.base/info-shared.exp b/gdb/testsuite/gdb.bas=
e/info-shared.exp
index 290ae5793dc..8d3484b186c 100644
--- a/gdb/testsuite/gdb.base/info-shared.exp
+++ b/gdb/testsuite/gdb.base/info-shared.exp
@@ -22,12 +22,10 @@ standard_testfile
 set lib1name $testfile-solib1
 set srcfile_lib1 $srcdir/$subdir/$lib1name.c
 set binfile_lib1 [standard_output_file $lib1name.so]
-set define1 -DSHLIB1_NAME=3D\"$binfile_lib1\"
=20
 set lib2name $testfile-solib2
 set srcfile_lib2 $srcdir/$subdir/$lib2name.c
 set binfile_lib2 [standard_output_file $lib2name.so]
-set define2 -DSHLIB2_NAME=3D\"$binfile_lib2\"
=20
 if { [gdb_compile_shlib $srcfile_lib1 $binfile_lib1 {}] !=3D "" } {
     untested "failed to compile shared library 1"
@@ -39,12 +37,21 @@ if { [gdb_compile_shlib $srcfile_lib2 $binfile_lib2 {}]=
 !=3D "" } {
     return -1
 }
=20
+set binfile_lib1_target [gdb_download_shlib $binfile_lib1]
+set binfile_lib2_target [gdb_download_shlib $binfile_lib2]
+
+set define2 -DSHLIB2_NAME=3D\"$binfile_lib2_target\"
+set define1 -DSHLIB1_NAME=3D\"$binfile_lib1_target\"
+
 set cflags "$define1 $define2"
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
 	  [list additional_flags=3D$cflags shlib_load]] } {
     return -1
 }
=20
+gdb_locate_shlib $binfile_lib1
+gdb_locate_shlib $binfile_lib2
+
 # Run "info sharedlibrary" and check for the presence or absence of
 # our libraries.
 proc check_info_shared { test expect1 expect2 } {