From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id 4A5ED3851892; Fri, 18 Nov 2022 11:46:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A5ED3851892 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668771982; bh=+jwYGZx46qd/yGC+BUynewTJgjJN1hiS10/C+m/g3Xk=; h=From:To:Subject:Date:From; b=xodp8bf4TzAWJv0STz4AuXGRJuawvop7d95USc8emsnFVX/QsV0i1SqRKs2EHYjXg wsupQYBR1DUWIoS7XMe7WCscSyezSdcM8sB6mCmePY0G9L1W9M+8B+q0lDooY75a1E Gf76oGQfD+EjGFQU4PSZjkDqvAk/fh6tOfglXWGA= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: don't avoid DWARF assembler tests with Clang X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: c963bda81e255dbac7c1acd31121d282a4910308 X-Git-Newrev: 6911239bbaa7b4365d3d0ff7b6cb296cfe43480c Message-Id: <20221118114622.4A5ED3851892@sourceware.org> Date: Fri, 18 Nov 2022 11:46:22 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D6911239bbaa7= b4365d3d0ff7b6cb296cfe43480c commit 6911239bbaa7b4365d3d0ff7b6cb296cfe43480c Author: Andrew Burgess Date: Fri Nov 11 15:21:56 2022 +0000 gdb/testsuite: don't avoid DWARF assembler tests with Clang =20 Two tests make the claim that the DWARF assembler requires gcc, however, this isn't true. I think at one point, when the DWARF assembler was first added, we did use some techniques that were not portable (see the comments in lib/dwarf.exp on function_range for details), however, I think most DWARF assembler tests will now work fine with Clang. =20 The two tests that I modify in this commit both work fine with Clang, at least, I've tested with Clang 9.0.1 and 15.0.2, and don't see any problems, so I'm removing the early return logic that stops these tests from running with Clang. =20 Reviewed-By: Lancelot SIX Diff: --- gdb/testsuite/gdb.base/until-trailing-insns.exp | 6 ------ gdb/testsuite/gdb.cp/incomplete-type-overload.exp | 5 ----- 2 files changed, 11 deletions(-) diff --git a/gdb/testsuite/gdb.base/until-trailing-insns.exp b/gdb/testsuit= e/gdb.base/until-trailing-insns.exp index 6396b6650c1..56f6cf038e2 100644 --- a/gdb/testsuite/gdb.base/until-trailing-insns.exp +++ b/gdb/testsuite/gdb.base/until-trailing-insns.exp @@ -84,12 +84,6 @@ if {![dwarf2_support]} { return 0 } =20 -# The DWARF assembler requires the gcc compiler. -if {![is_c_compiler_gcc]} { - unsupported "gcc is required for this test" - return 0 -} - standard_testfile .c .S =20 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { diff --git a/gdb/testsuite/gdb.cp/incomplete-type-overload.exp b/gdb/testsu= ite/gdb.cp/incomplete-type-overload.exp index 96ed25dd5d1..024014d68ba 100644 --- a/gdb/testsuite/gdb.cp/incomplete-type-overload.exp +++ b/gdb/testsuite/gdb.cp/incomplete-type-overload.exp @@ -31,11 +31,6 @@ if [prepare_for_testing "failed to prepare" $testfile $s= rcfile {debug c++}] { return } =20 -if {[test_compiler_info clang-*-*]} { - untested "gcc is required for dwarf assembler tests" - return -} - if ![runto_main] { return }