From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1936) id AA0F8385456F; Tue, 22 Nov 2022 22:43:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA0F8385456F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669157031; bh=CbIyqwuRvXf4nhlqioSyJOkTSHh7Wim1fIs2XhH+4eQ=; h=From:To:Subject:Date:From; b=ptDRcJOJJTWkYJySJNSp0LycDZP9UVlfaht8lEP2+KAYeeIcEcyirl1/4D5djdnR/ zoIttt2pwlYkyovUDW4B+Ctrl7lR5JA5+96ulIBDPGY/wEK12DadCPqffA1U1w1RJr u8z+XVQ9d9CA4fNQIAqXOxfoaNcV37gEJcLEnUIY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: John Baldwin To: gdb-cvs@sourceware.org Subject: [binutils-gdb] fbsd-nat: Use regset supply/collect methods. X-Act-Checkin: binutils-gdb X-Git-Author: John Baldwin X-Git-Refname: refs/heads/master X-Git-Oldrev: 0ee9f16cf9ff849fda1555033ae0ce78d028bf86 X-Git-Newrev: 5dd6c79a323a9ca7bf8d5db3206532580365127e Message-Id: <20221122224351.AA0F8385456F@sourceware.org> Date: Tue, 22 Nov 2022 22:43:51 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D5dd6c79a323a= 9ca7bf8d5db3206532580365127e commit 5dd6c79a323a9ca7bf8d5db3206532580365127e Author: John Baldwin Date: Tue Nov 22 14:21:13 2022 -0800 fbsd-nat: Use regset supply/collect methods. =20 fbsd-nat includes various helper routines for fetching and storing register sets via ptrace where the register set is described by a regset. These helper routines directly invoke the supply/collect_regset regcache methods which doesn't permit a regset to provide custom logic when fetching or storing a register set. Instead, just use the function pointers from the struct regset directly. =20 Approved-By: Simon Marchi Diff: --- gdb/fbsd-nat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index ad26503a2ad..7d279810483 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -1744,7 +1744,7 @@ fbsd_nat_target::fetch_register_set (struct regcache = *regcache, int regnum, if (ptrace (fetch_op, pid, (PTRACE_TYPE_ARG3) regs, 0) =3D=3D -1) perror_with_name (_("Couldn't get registers")); =20 - regcache->supply_regset (regset, regnum, regs, size); + regset->supply_regset (regset, regcache, regnum, regs, size); return true; } return false; @@ -1768,7 +1768,7 @@ fbsd_nat_target::store_register_set (struct regcache = *regcache, int regnum, if (ptrace (fetch_op, pid, (PTRACE_TYPE_ARG3) regs, 0) =3D=3D -1) perror_with_name (_("Couldn't get registers")); =20 - regcache->collect_regset (regset, regnum, regs, size); + regset->collect_regset (regset, regcache, regnum, regs, size); =20 if (ptrace (store_op, pid, (PTRACE_TYPE_ARG3) regs, 0) =3D=3D -1) perror_with_name (_("Couldn't write registers")); @@ -1813,7 +1813,7 @@ fbsd_nat_target::fetch_regset (struct regcache *regca= che, int regnum, int note, if (ptrace (PT_GETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) =3D=3D= -1) perror_with_name (_("Couldn't get registers")); =20 - regcache->supply_regset (regset, regnum, regs, size); + regset->supply_regset (regset, regcache, regnum, regs, size); return true; } return false; @@ -1838,7 +1838,7 @@ fbsd_nat_target::store_regset (struct regcache *regca= che, int regnum, int note, if (ptrace (PT_GETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) =3D=3D= -1) perror_with_name (_("Couldn't get registers")); =20 - regcache->collect_regset (regset, regnum, regs, size); + regset->collect_regset (regset, regcache, regnum, regs, size); =20 if (ptrace (PT_SETREGSET, pid, (PTRACE_TYPE_ARG3) &iov, note) =3D=3D= -1) perror_with_name (_("Couldn't write registers"));