public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite/gdb.base/break.exp: split test_break_file_line_convenience_var Date: Thu, 24 Nov 2022 15:22:59 +0000 (GMT) [thread overview] Message-ID: <20221124152259.C9E2C3830B21@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b6cb5e17b84787f6832e2d35602dd17ed3855e62 commit b6cb5e17b84787f6832e2d35602dd17ed3855e62 Author: Simon Marchi <simon.marchi@polymtl.ca> Date: Wed Nov 23 13:39:47 2022 -0500 gdb/testsuite/gdb.base/break.exp: split test_break_file_line_convenience_var Change-Id: I0c31b037669b2917e062bf431372fb6531f8f53c Approved-By: Kevin Buettner <kevinb@redhat.com> Diff: --- gdb/testsuite/gdb.base/break.exp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index c0756cdccc2..be349d9e7ea 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -868,18 +868,18 @@ gdb_test_multiple "" $test { } } -# # Test break via convenience variable with file name -# -with_test_prefix "set line:file breakpoint via convenience variable" { +proc_with_prefix test_break_file_line_convenience_var {} { + clean_restart breako2 + set line [gdb_get_line_number "set breakpoint 1 here"] gdb_test_no_output "set \$l = $line" set line_actual "-1" - set test "break ${srcfile}:\$l" + set test "break $::srcfile:\$l" gdb_test_multiple "$test" $test { - -re "Breakpoint $decimal at $hex: file .*break\\.c, line ($decimal)\\.\r\n$gdb_prompt $" { + -re "Breakpoint $::decimal at $::hex: file .*break\\.c, line ($::decimal)\\.\r\n$::gdb_prompt $" { # Save the actual line number on which the breakpoint was # actually set. On some systems (Eg: Ubuntu 16.04 with GCC # version 5.4.0), that line gets completely inlined, including @@ -892,11 +892,13 @@ with_test_prefix "set line:file breakpoint via convenience variable" { gdb_test_no_output "set \$foo=81.5" \ "set convenience variable \$foo to 81.5" - gdb_test "break $srcfile:\$foo" \ + gdb_test "break $::srcfile:\$foo" \ "Convenience variables used in line specs must have integer values.*" \ "non-integer convenience variable disallowed" } +test_break_file_line_convenience_var + # Test that commands can be cleared without error. proc_with_prefix test_break_commands_clear {} {
reply other threads:[~2022-11-24 15:22 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221124152259.C9E2C3830B21@sourceware.org \ --to=simark@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).