public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite/gdb.base/break.exp: split test_break_line_convenience_var
Date: Thu, 24 Nov 2022 15:23:30 +0000 (GMT)	[thread overview]
Message-ID: <20221124152330.3F14D38518BE@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e89425fec2fbeb93ad27477304281c202d72d8ae

commit e89425fec2fbeb93ad27477304281c202d72d8ae
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Wed Nov 23 13:39:53 2022 -0500

    gdb/testsuite/gdb.base/break.exp: split test_break_line_convenience_var
    
    Change-Id: I593002373da971a0a4d6b5355d3fe321873479ab
    Approved-By: Kevin Buettner <kevinb@redhat.com>

Diff:
---
 gdb/testsuite/gdb.base/break.exp | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp
index d9cfeb9b21f..cc327c195f4 100644
--- a/gdb/testsuite/gdb.base/break.exp
+++ b/gdb/testsuite/gdb.base/break.exp
@@ -604,18 +604,22 @@ gdb_test "break marker3" "Breakpoint.*at.*" "break marker3 #2"
 gdb_test "clear marker3" {Deleted breakpoints [0-9]+ [0-9]+.*}
 
 # Verify that a breakpoint can be set via a convenience variable.
-#
 
-with_test_prefix "set line breakpoint via convenience variable" {
-    gdb_test_no_output "set \$foo=$bp_location11" \
+proc_with_prefix test_break_line_convenience_var {} {
+    clean_restart break
+
+    if { ![runto_main] } {
+	return
+    }
+
+    gdb_test_no_output "set \$foo=$::bp_location11" \
 	"set convenience variable \$foo to bp_location11"
 
     gdb_test "break \$foo" \
-	"Breakpoint (\[0-9\]*) at .*, line $bp_location11.*"
+	"Breakpoint (\[0-9\]*) at .*, line $::bp_location11.*"
 
     # Verify that GDB responds gracefully to an attempt to set a
     # breakpoint via a convenience variable whose type is not integer.
-    #
 
     gdb_test_no_output "set \$foo=81.5" \
 	"set convenience variable \$foo to 81.5"
@@ -625,6 +629,8 @@ with_test_prefix "set line breakpoint via convenience variable" {
 	"non-integer convenience variable disallowed"
 }
 
+test_break_line_convenience_var
+
 # Verify that we can set and trigger a breakpoint in a user-called function.
 
 proc_with_prefix test_break_user_call {} {

                 reply	other threads:[~2022-11-24 15:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124152330.3F14D38518BE@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).