public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] fix leak in gdb_environ Date: Sun, 27 Nov 2022 20:08:37 +0000 (GMT) [thread overview] Message-ID: <20221127200837.2BD903858C50@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c801f8f138c03cde994db597d11953c21ed892de commit c801f8f138c03cde994db597d11953c21ed892de Author: Philippe Waroquiers <philippe.waroquiers@skynet.be> Date: Sun Nov 27 19:20:58 2022 +0100 fix leak in gdb_environ valgrind reports a leak when assigning a gdb_environ to another gdb_environ. The memory allocated for the target gdb_environ env variables is not released. The gdb_environ selftest reproduces the leak (see below). Fix the leak by clearing the target gdb_environ before std::move-ing the members. Tested natively and re-running all tests under valgrind. ==3261873== 4,842 bytes in 69 blocks are definitely lost in loss record 6,772 of 6,839 ==3261873== at 0x483979B: malloc (vg_replace_malloc.c:393) ==3261873== by 0x25A454: xmalloc (alloc.c:57) ==3261873== by 0x7D1E4E: xstrdup (xstrdup.c:34) ==3261873== by 0x7E2A51: gdb_environ::from_host_environ() (environ.cc:56) ==3261873== by 0x66F1C8: test_reinit_from_host_environ (environ-selftests.c:78) ==3261873== by 0x66F1C8: selftests::gdb_environ_tests::run_tests() (environ-selftests.c:285) ==3261873== by 0x7EFC43: operator() (std_function.h:622) = Approved-By: Simon Marchi <simon.marchi@efficios.com> Diff: --- gdbsupport/environ.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdbsupport/environ.cc b/gdbsupport/environ.cc index f5f6b38e19c..2d8e3ea6e92 100644 --- a/gdbsupport/environ.cc +++ b/gdbsupport/environ.cc @@ -29,6 +29,8 @@ gdb_environ::operator= (gdb_environ &&e) if (&e == this) return *this; + this->clear (); + m_environ_vector = std::move (e.m_environ_vector); m_user_set_env = std::move (e.m_user_set_env); m_user_unset_env = std::move (e.m_user_unset_env);
reply other threads:[~2022-11-27 20:08 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221127200837.2BD903858C50@sourceware.org \ --to=philippe@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).