public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le
Date: Mon, 28 Nov 2022 16:18:50 +0000 (GMT)	[thread overview]
Message-ID: <20221128161850.4D59B3857C51@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b4bb9faa78c7454e9aafa4fbdbf76e4206acd14a

commit b4bb9faa78c7454e9aafa4fbdbf76e4206acd14a
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Nov 28 17:18:47 2022 +0100

    [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le
    
    On powerpc64le-linux, with test-case gdb.ada/out_of_line_in_inlined.exp I run
    into:
    ...
    (gdb) run ^M
    Starting program: foo_o224_021-all ^M
    ^M
    Breakpoint 1, 0x0000000010002f48 in foo_o224_021.child1.child2 (s=...) at \
      foo_o224_021.adb:24^M
    24              function Child2 (S : String) return Boolean is -- STOP^M
    (gdb) FAIL: gdb.ada/out_of_line_in_inlined.exp: scenario=all: \
      run to foo_o224_021.child1.child2
    ...
    
    The breakpoint is correctly set at the local entry point, and given that the
    local entry point doesn't correspond to a line number entry, the instruction
    address of the breakpoint is shown.
    
    The problem is that test-case doesn't expect the breakpoint address.
    
    Fix this by allowing the breakpoint address to occur.
    
    Tested on powerpc64le-linux.

Diff:
---
 gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
index 4bdb4decaaf..621b04e179b 100644
--- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
+++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
@@ -34,7 +34,7 @@ foreach_with_prefix scenario {all minimal} {
 
     gdb_run_cmd
     gdb_test "" \
-	"Breakpoint $decimal, foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \
+	"Breakpoint $decimal, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \
 	"run to foo_o224_021.child1.child2"
 
     set opt_addr_in "($hex in)?"

                 reply	other threads:[~2022-11-28 16:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221128161850.4D59B3857C51@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).