From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id B91DA385703A; Thu, 1 Dec 2022 06:25:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B91DA385703A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669875913; bh=kKnzo0gLc7Kk6+Ltlhsxtj4yyFWPE2wPOdN/jrcHnzI=; h=From:To:Subject:Date:From; b=Vm0Q907kEBMO1G1xvX5AfKFJNIuc1wlDFLpprpLG+hfigbdDQ7m1xuJ20umpRlXrg n1sdYtJk+9PdV55sUZP+AEMiEABCYwZZo/5kd1wdv3ttyBqJl/1DpKaRJfnhTqN9X3 1fFlXnP7vlZQVTMEMCnWPeGXfr0O9o6jY0qcFdBA= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Wait longer for core generation X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: 32a5aa2625686a709b22db19300a578d96285dd1 X-Git-Newrev: f0cb4aa909d0e3c1c656b2ba9758a59a2cde75de Message-Id: <20221201062513.B91DA385703A@sourceware.org> Date: Thu, 1 Dec 2022 06:25:13 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Df0cb4aa909d0= e3c1c656b2ba9758a59a2cde75de commit f0cb4aa909d0e3c1c656b2ba9758a59a2cde75de Author: Tom de Vries Date: Thu Dec 1 07:25:04 2022 +0100 [gdb/testsuite] Wait longer for core generation =20 When I run the gdb testsuite on a powerpc64le-linux system with (slow) = nfs file system, I run into timeouts due to core generation, like for insta= nce: ... (gdb) gcore $outputs/gdb.ada/task_switch_in_core/crash.gcore^M FAIL: gdb.ada/task_switch_in_core.exp: save a corefile (timeout) ... =20 Fix this by using with_timeout_factor 3 in gdb_gcore_cmd. =20 Tested on powerpc64le-linux. Approved-By: Tom Tromey Diff: --- gdb/testsuite/lib/gdb.exp | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 23e3cc0c2d4..f41fc1375aa 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5730,13 +5730,19 @@ proc gdb_gcore_cmd {core test} { global gdb_prompt =20 set result 0 - gdb_test_multiple "gcore $core" $test { - -re "Saved corefile .*\[\r\n\]+$gdb_prompt $" { - pass $test - set result 1 - } - -re "(?:Can't create a corefile|Target does not support core file generat= ion\\.)\[\r\n\]+$gdb_prompt $" { - unsupported $test + + set re_unsupported \ + "(?:Can't create a corefile|Target does not support core file generation\= \.)" + + with_timeout_factor 3 { + gdb_test_multiple "gcore $core" $test { + -re -wrap "Saved corefile .*" { + pass $test + set result 1 + } + -re -wrap $re_unsupported { + unsupported $test + } } }