From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id B2BB239524A2; Mon, 5 Dec 2022 21:39:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2BB239524A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670276351; bh=UoGoNXl/HoqTCu+UMxKtR87YecQmGBMeyWi4wt9OaFc=; h=From:To:Subject:Date:From; b=P5chNytC9jttUWg/Dy0VWDfrws3o6WGkoFaIuszHi9m+8LKHChXqxCKf3IHY9Xv5n rjUYalPUUll9+0FJB4mLPtJiX1vuQQ0HOIeZpT2lDrLV5p7lG7DkjubpRHdJ0S8f76 9n1kTLrbh6YkV7lvSc7YYl8Ogx6BM59bzlot2I0Y= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo X-Act-Checkin: binutils-gdb X-Git-Author: Simon Marchi X-Git-Refname: refs/heads/master X-Git-Oldrev: ef632b4bf84e6e60e58b76b7e7471c82e1507854 X-Git-Newrev: 8aa1556f2e88851f9bfcacd3f624c8182946a6f6 Message-Id: <20221205213911.B2BB239524A2@sourceware.org> Date: Mon, 5 Dec 2022 21:39:11 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D8aa1556f2e88= 851f9bfcacd3f624c8182946a6f6 commit 8aa1556f2e88851f9bfcacd3f624c8182946a6f6 Author: Simon Marchi Date: Fri Dec 2 15:09:22 2022 -0500 gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo =20 No caller cares about the value of *SIGINFO on failure. It's also documented in the function doc that *SIGINFO is uninitialized (I understand "untouched") on failure. =20 Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a Diff: --- gdb/linux-nat.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 7b6a1f98d66..c47b8db9299 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -4446,12 +4446,8 @@ linux_nat_get_siginfo (ptid_t ptid, siginfo_t *sigin= fo) =20 errno =3D 0; ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo); - if (errno !=3D 0) - { - memset (siginfo, 0, sizeof (*siginfo)); - return false; - } - return true; + + return errno =3D=3D 0; } =20 /* See nat/linux-nat.h. */