public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo
@ 2022-12-05 21:39 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-12-05 21:39 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb

commit 7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Dec 2 15:09:23 2022 -0500

    gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo
    
    Not a big deal, but it seems strange to check errno instead of the
    ptrace return value to know whether it succeeded.
    
    Change-Id: If0a6d0280ab0e5ecb077e546af0d6fe489c5b9fd

Diff:
---
 gdb/linux-nat.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index c47b8db9299..b33fac3d149 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4443,11 +4443,7 @@ bool
 linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
 {
   int pid = get_ptrace_pid (ptid);
-
-  errno = 0;
-  ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
-
-  return errno == 0;
+  return ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo) == 0;
 }
 
 /* See nat/linux-nat.h.  */

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2022-12-05 21:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 21:39 [binutils-gdb] gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).